Add IPC tests (umfIpcTest) to the devdax provider - #845
Merged
ldorau merged 3 commits intoNov 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
3 tasks
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
3 times, most recently
from
7ad3d15 to
0685486
Compare
October 29, 2024 09:03
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
135902a to
1d2b1d5
Compare
October 30, 2024 10:03
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
1d2b1d5 to
b96b7e3
Compare
October 30, 2024 15:10
3 tasks
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
2 times, most recently
from
9adda39 to
e0c08bb
Compare
October 31, 2024 14:27
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
e0c08bb to
7816b4a
Compare
October 31, 2024 15:15
ldorau
marked this pull request as ready for review
October 31, 2024 15:16
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
7816b4a to
96a335c
Compare
October 31, 2024 15:42
vinser52
requested changes
Oct 31, 2024
Comment thread
test/provider_devdax_memory.cpp
Outdated
Comment thread
test/ipcFixtures.hpp
Outdated
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
96a335c to
79b8d2a
Compare
October 31, 2024 21:26
vinser52
requested changes
Nov 1, 2024
Comment thread
test/provider_devdax_memory.cpp
Outdated
Comment thread
test/provider_os_memory.cpp
Comment thread
test/ipcFixtures.hpp
Outdated
Some memory providers (currently the devdax and the file providers) do not support the free() operation (free() always returns the UMF_RESULT_ERROR_NOT_SUPPORTED error). Add the `free_not_supp` parameter to `ipcTestParams` in ipcFixtures.hpp that says if the provider does not support the free() op to enable running umfIpcTest tests when free() is not supported. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
7 times, most recently
from
fba7fe9 to
41021ac
Compare
November 4, 2024 08:26
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
41021ac to
ca20ebb
Compare
November 4, 2024 08:30
4 tasks
vinser52
reviewed
Nov 4, 2024
Comment thread
test/pools/ipc_jemalloc_devdax.cpp
Outdated
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Add_IPC_tests_umfIpcTest_to_the_devdax_provider
branch
from
ca20ebb to
486b3e4
Compare
November 4, 2024 14:47
vinser52
approved these changes
Nov 4, 2024
bratpiorka
approved these changes
Nov 4, 2024
7 tasks
bratpiorka
marked this pull request as draft
November 4, 2024 16:54
Copy link
Copy Markdown
I have two questions/comments:
|
Sorry, something went wrong.
bratpiorka
marked this pull request as ready for review
November 4, 2024 17:03
Copy link
Copy Markdown
Contributor
|
ok we can merge this if CI passes |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add IPC tests (umfIpcTest) to the devdax provider.
Checklist