FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix updated EmbJSON path handling by xiaolu-ai26 · Pull Request #4 · onenodehq/onenode · GitHub

Fix updated EmbJSON path handling - #4

Open
xiaolu-ai26 wants to merge 2 commits into
onenodehq:mainfrom
xiaolu-ai26:fix-xtext-update-path
Open

Fix updated EmbJSON path handling#4
xiaolu-ai26 wants to merge 2 commits into
onenodehq:mainfrom
xiaolu-ai26:fix-xtext-update-path

Conversation

Copy link
Copy Markdown

Summary

Fixes #3.

This keeps semantic index paths consistent when PUT /document updates a field that contains xText or xImage.

Changes:

  • pass the updated field path into process_document() from process_update()
  • thread collection_name through delete_overwritten_pc_vectors()
  • build old-vector deletion prefixes as project#db#collection#doc#path

Validation

I verified the helper behavior with Pinecone/MinIO stubbed so the path logic can be checked without external services:

CREATE_VECTOR_ID= proj#db#items#doc1#description#0
CREATE_METADATA_PATH= description
UPDATE_VECTOR_ID= proj#db#items#doc1#description#0
UPDATE_METADATA_PATH= 'description'
DELETE_CALLS= [('proj', 'db', 'proj#db#items#doc1#description')]
PASS

Also ran:

python3 -m compileall -q blueprints/v0/project/db/collection/document/helper.py blueprints/v0/project/db/collection/document/services.py

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xText update vectors lose their field path

1 participant


Back | FazBrowse Home | New Git URL