FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FLIP: Allow adding new fields to existing types by turbolent · Pull Request #295 · onflow/flips · GitHub

/ flips Public

FLIP: Allow adding new fields to existing types - #295

Open
turbolent wants to merge 8 commits into
mainfrom
bastian/cadence-add-fields
ConversationCommits (8)ChecksFiles changed
Open

FLIP: Allow adding new fields to existing types#295
turbolent wants to merge 8 commits into
mainfrom
bastian/cadence-add-fields

Conversation

turbolent commented Oct 22, 2024

Copy link
Copy Markdown
Member

Moved from onflow/flow#1097

Please see the initial discussion there

turbolent self-assigned this Oct 22, 2024
turbolent requested a review from a team October 22, 2024 22:52
turbolent mentioned this pull request Oct 22, 2024
Closed
5 tasks
SupunS reviewed Oct 22, 2024
View reviewed changes

SupunS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👌

Comment thread cadence/20220817-add-fields-to-existing-definitions.md

turbolent commented Oct 23, 2024

Copy link
Copy Markdown
Member Author

cc @austinkline @bluesign @bjartek

turbolent mentioned this pull request Oct 23, 2024
Closed

turbolent commented Oct 30, 2024

Copy link
Copy Markdown
Member Author

@austinkline We had a working group discussion about this FLIP yesterday, see https://github.com/onflow/Flow-Working-Groups/blob/main/cadence_language_and_execution_working_group/meetings/2024-10-29.md#flips.

Feedback has been that it is a low priority feature, and given the complicated situation (existing stored state with "removed" fields) and the dependency on first having to prevent field removal (for both, see https://github.com/onflow/flips/pull/295/files#diff-6243eb63ad4bcc7c53d3b54c65552ad22149247ebef272dbb0413115b04e989aR104-R116), there is unfortunately quite a lot of effort required to implement this FLIP.

Consensus has been that there are more important proposals to get in, and this proposal will be on hold, unless there is a strong reason to justify the effort. What do you think about this?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

SupunS SupunS left review comments

At least 1 approving review is required to merge this pull request.

Assignees

turbolent

Labels

flip: cadence

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL