FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add Statsig provider by liran2000 · Pull Request #641 · open-feature/java-sdk-contrib · GitHub

/ java-sdk-contrib Public

feat: Add Statsig provider - #641

Merged
Kavindu-Dodan merged 12 commits into
open-feature:mainfrom
liran2000:feature/statsig
Feb 2, 2024
ConversationCommits (12)ChecksFiles changed
Merged

feat: Add Statsig provider#641
Kavindu-Dodan merged 12 commits into
open-feature:mainfrom
liran2000:feature/statsig

Conversation

liran2000 commented Jan 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Readme describes the provider.

@MovieStoreGuy @jasonwzm @xinlili-statsig @toddbaert you are welcome to review.

liran2000 requested a review from a team as a code owner January 18, 2024 09:18
toddbaert previously approved these changes Jan 31, 2024
View reviewed changes

toddbaert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM @liran2000 , thanks again.

@xinlili-statsig are you interested in being added to the component_owners for this component? It will mean you are added to PRs that impact it. Note you will have to join the OpenFeature org in that case.

@liran2000 please add yourself to https://github.com/open-feature/java-sdk-contrib/blob/main/.github/component_owners.yml for this at a minimum.

Also, you may be interested in this issue since you've authored quite a few providers.

toddbaert dismissed their stale review January 31, 2024 15:11

component owners

toddbaert approved these changes Feb 2, 2024
View reviewed changes

toddbaert left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey @liran2000 I led you wrong, I said to use InvalidContextError but we have TargetingKeyMissingError, so I recommend that... so I made that change. Sorry!

Comment thread ...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java Outdated
Comment thread ...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java Outdated

toddbaert commented Feb 2, 2024

Copy link
Copy Markdown
Member

@Kavindu-Dodan when you have a moment, please review and feel free to merge if it looks OK.

xinlili-statsig approved these changes Feb 2, 2024
View reviewed changes

xinlili-statsig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall lgtm!

Statsig provider initial draft
2e41a9e 
Signed-off-by: liran2000 <liran2000@gmail.com>
add Statsig provider
f463aee 
Signed-off-by: liran2000 <liran2000@gmail.com>
minor updates
9b2acd4 
Signed-off-by: liran2000 <liran2000@gmail.com>
change concept to feature config
d5bb56f 
Signed-off-by: liran2000 <liran2000@gmail.com>
add Object evaluation support
b541c98 
Signed-off-by: liran2000 <liran2000@gmail.com>
minor updates
440463a 
Signed-off-by: liran2000 <liran2000@gmail.com>
docs updates
e2fbedc 
Signed-off-by: liran2000 <liran2000@gmail.com>
remove try catch blocks
8c06bb3 
Signed-off-by: liran2000 <liran2000@gmail.com>
update fields scope
50b4731 
Signed-off-by: liran2000 <liran2000@gmail.com>
liran2000 and others added 3 commits February 2, 2024 14:39
updates
fb54330 
Signed-off-by: liran2000 <liran2000@gmail.com>
Update providers/statsig/src/main/java/dev/openfeature/contrib/provid…
19fa93a 
…ers/statsig/ContextTransformer.java

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Update providers/statsig/src/main/java/dev/openfeature/contrib/provid…
dce0a7e 
…ers/statsig/ContextTransformer.java

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Kavindu-Dodan commented Feb 2, 2024

Copy link
Copy Markdown
Collaborator

Merging as this is approved by @xinlili-statsig. Also, looks good in my view and there's good test coverage.

Kavindu-Dodan merged commit f814696 into open-feature:main Feb 2, 2024
liran2000 deleted the feature/statsig branch February 3, 2024 07:05
github-actions Bot mentioned this pull request Feb 8, 2024
Merged
liran2000 mentioned this pull request Feb 22, 2024
Closed
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
chore(deps): update github/codeql-action digest to 3dd4ad8 (open-feat…
15dae81 
…ure#641)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mahpatil pushed a commit to mahpatil/java-sdk-contrib that referenced this pull request Jun 3, 2026
feat: Add Statsig provider (open-feature#641)
51a793d 
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kavindu-Dodan Kavindu-Dodan approved these changes
toddbaert toddbaert approved these changes
beeme1mr Awaiting requested review from beeme1mr
+1 more reviewer
xinlili-statsig xinlili-statsig approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

liran2000

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL