FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add gRPC authenticator for exporter by saxocellphone · Pull Request #6952 · open-telemetry/opentelemetry-java · GitHub

Add gRPC authenticator for exporter - #6952

Closed
saxocellphone wants to merge 1 commit into
open-telemetry:mainfrom
saxocellphone:add_grpc_authentication
Closed

Add gRPC authenticator for exporter#6952
saxocellphone wants to merge 1 commit into
open-telemetry:mainfrom
saxocellphone:add_grpc_authentication

Conversation

saxocellphone commented Dec 13, 2024
edited
Loading

Copy link
Copy Markdown

Adding missing gRPC authentication features to the experimental Authenticator api. Closes #6953

saxocellphone requested a review from a team as a code owner December 13, 2024 01:08

linux-foundation-easycla Bot commented Dec 13, 2024
edited
Loading

Copy link
Copy Markdown



The committers listed above are authorized under a signed CLA.

codecov Bot commented Dec 13, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.06%. Comparing base (e3cfede) to head (8713eed).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...orter/sender/okhttp/internal/OkHttpGrpcSender.java 10.00% 8 Missing and 1 partial ⚠️
...edchannel/internal/UpstreamGrpcSenderProvider.java 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6952      +/-   ##
============================================
- Coverage     90.09%   90.06%   -0.03%     
- Complexity     6601     6603       +2     
============================================
  Files           730      730              
  Lines         19843    19864      +21     
  Branches       1955     1958       +3     
============================================
+ Hits          17877    17890      +13     
- Misses         1371     1379       +8     
  Partials        595      595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

saxocellphone marked this pull request as draft December 13, 2024 01:17
saxocellphone force-pushed the add_grpc_authentication branch 3 times, most recently from d4606bf to 05f6085 Compare December 13, 2024 20:49
saxocellphone marked this pull request as ready for review December 13, 2024 21:22
saxocellphone marked this pull request as draft December 13, 2024 21:53

saxocellphone commented Dec 13, 2024
edited
Loading

Copy link
Copy Markdown
Author

I was trying to figure out why the build-graal check is failing. It's complaining about changing a static variable in io.opentelemetry.exporter.internal.auth.Authenticator. Which is WAI. Is the test flaky?

EDIT: fixed by adding the following to resources/META-INF/native-image/io.opentelemetry.opentelemetry-exporter-common/reflect-config.json

  {
    "name":"io.opentelemetry.exporter.internal.auth.Authenticator",
    "queryAllDeclaredMethods":true
  }

saxocellphone marked this pull request as ready for review December 13, 2024 22:26

jack-berg commented Jan 6, 2025
edited
Loading

Copy link
Copy Markdown
Member

As discussed in #6975, the Authenticator was conceptually flawed and was removed in #6984.

Users should instead use setHeaders(Supplier<Map<String, String>>) for dynamic header based authentication requirements, as demonstrated in this docs PR.

Update: Docs PR merged and available here

jack-berg closed this Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add authentication support for GrpcExporter

2 participants


Back | FazBrowse Home | New Git URL