| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Here are some automated review suggestions for this pull request.
Reviewed commit: eccb932db2
ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Sorry, something went wrong.
| if self._on_reconnecting is None or self._make_ws is None: | ||
| return False |
There was a problem hiding this comment.
Allow reconnect attempts without requiring a callback
The reconnect path is effectively disabled unless on_reconnecting is provided: _reconnect() returns immediately when _on_reconnecting is None, so callers that set max_retries/delays but omit the callback will never retry and will still fail on the first disconnect. This makes the new retry parameters inert in the default usage path and prevents the advertised websocket reconnection behavior for most clients.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| except ConnectionClosedOK: | ||
| return |
There was a problem hiding this comment.
Route recoverable "OK" closes through reconnect logic
The iterator returns immediately on ConnectionClosedOK, so close code 1001 (explicitly marked recoverable in types/websocket_reconnection.py) never reaches _reconnect(). In practice, transient server "going away" closures will terminate iteration instead of retrying, despite being classified as recoverable.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
|
🤖 Release is at https://github.com/openai/openai-python/releases/tag/v2.32.0 🌻 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Automated Release PR
2.32.0 (2026-04-15)
Full Changelog: v2.31.0...v2.32.0
Features
Bug Fixes
Documentation
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions