FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Azure] CLI: Add support for azure openai chat completion API by iaalm · Pull Request #359 · openai/openai-python · GitHub

/ openai-python Public

[Azure] CLI: Add support for azure openai chat completion API - #359

Merged
athyuttamre merged 1 commit into
openai:mainfrom
iaalm:main
Apr 4, 2023
ConversationCommits (1)ChecksFiles changed
Merged

[Azure] CLI: Add support for azure openai chat completion API#359
athyuttamre merged 1 commit into
openai:mainfrom
iaalm:main

Conversation

iaalm commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

The Azure API need to pass parameter engine. Follow the pattern Completion.create to make model optional and add engine as a parameter too.

Tested on Azure OpenAI API passed with

openapi api chat_completions.create -e chatgpt -g user "hello"

iaalm mentioned this pull request Mar 30, 2023
Closed
iaalm changed the title Add support for azure openai chat completion API [Azure] CLI: Add support for azure openai chat completion API Mar 30, 2023
hallacy requested a review from athyuttamre March 30, 2023 18:36

iaalm commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

@athyuttamre could you help review?

athyuttamre reviewed Apr 4, 2023
View reviewed changes
Comment thread openai/cli.py Outdated
athyuttamre reviewed Apr 4, 2023
View reviewed changes
Comment thread openai/cli.py Outdated
athyuttamre approved these changes Apr 4, 2023
View reviewed changes

athyuttamre left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Two non-blocking comments, thanks for the PR!

iaalm commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

@athyuttamre Thank you for the review. Updated based on your comment.

athyuttamre approved these changes Apr 4, 2023
View reviewed changes

athyuttamre left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! I can cut a new release immediately or we can wait for other PRs (#337) from Microsoft to land. What do you prefer?

iaalm commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

@athyuttamre Both should work. As this one works on its own, maybe we can merge it now?

athyuttamre merged commit ed821c8 into openai:main Apr 4, 2023

athyuttamre commented Apr 4, 2023

Copy link
Copy Markdown

Great! I need a stamp from a teammate to publish a version, will do so once this is approved: #373.

athyuttamre commented Apr 4, 2023

Copy link
Copy Markdown

This has been published in https://pypi.org/project/openai/0.27.4/.

davedittrich pushed a commit to davedittrich/openai-python that referenced this pull request Nov 14, 2023
add support for azure openai api (openai#359)
bffe30a
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
add support for azure openai api (openai#359)
830a6e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
athyuttamre athyuttamre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL