Repository navigation
fix: Initialize optional lists as UNSET, not [] - #1346
Merged
dbanty merged 1 commit intoOct 31, 2025
Merged
dbanty merged 1 commit into
dbanty merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…n from_dict Optional list properties were being initialized with empty lists [] instead of UNSET when calling from_dict() with missing values. This caused unnecessary empty arrays to be included in API request payloads. The fix modifies the list_property.py.jinja template to: - Initialize optional list properties as UNSET with proper type annotations - Only create and populate lists when the source value is not UNSET - Preserve existing behavior for required list properties Fixes: openapi-generators#1305 Fixes: openapi-generators#961
dbanty
approved these changes
Oct 31, 2025
dbanty
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks great, thanks!
Sorry, something went wrong.
dbanty
enabled auto-merge
October 31, 2025 14:48
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Fixes - Remove non-existent CHANGELOG.md references from UV and Poetry templates (#1344) - Initialize optional lists as UNSET, not [] (#1346) - Correct docstring typos in client template (#1347) - Replace bare except blocks with specific exception types (#1348) ### Update `uv_build` to 0.9 #1352 by @johnthagen `uv` has been in the `0.9.x` release cycle for a while, so update templates to use the corresponding `uv_build` range. Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional list properties were being incorrectly initialized with empty lists [] instead of UNSET when calling from_dict() with missing values. This breaks the semantic distinction between an omitted field and a field explicitly set to an empty list, which matters for PATCH operations and APIs that treat these cases differently.
Changes
The fix modifies the list_property.py.jinja template to:
Test Plan
Fixes #1305
Fixes #961