Repository navigation
Fix bad code generation - #1360
Merged
dbanty merged 4 commits intoDec 3, 2025
Merged
dbanty merged 4 commits into
dbanty merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dbanty
approved these changes
Dec 3, 2025
dbanty
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Lovely, thanks!
Sorry, something went wrong.
dbanty
enabled auto-merge
December 3, 2025 20:39
Merged
This was referenced Dec 3, 2025
Closed
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Breaking Changes - URL-encode path parameters in generated endpoints (#1349) ## Fixes ### Fix bad code generation #1360 by @EricAtORS This fixes: - missing parenthesis in to_multipart #1338 #1318 - missing imports in the lazy eval in to_multipart: #931 and #1051 ### Fix optional bodies If a body is not required (the default), it will now: 1. Have `Unset` as part of its type annotation. 2. Default to a value of `UNSET` 3. Not be included in the request if it is `UNSET` Thanks @orelmaliach for the report! Fixes #1354 Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had some issues with the code generation.
This should fix:
Broken UUID multipart template #1338 Bad code generation #1318
Missing lazy_import in model to_multipart() #931 and Missing lazy import in post body to_multipart function #1051