FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Remove some generated casts that aren't necessary with mypy v2 by renovate[bot] · Pull Request #1436 · openapi-generators/openapi-python-client · GitHub

  1. openapi-generators
  2. openapi-python-client

Repository navigation

fix: Remove some generated casts that aren't necessary with mypy v2 - #1436

Merged
dbanty merged 2 commits into
mainfrom
renovate/lock-file-maintenance
May 25, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: Remove some generated casts that aren't necessary with mypy v2#1436
dbanty merged 2 commits into
mainfrom
renovate/lock-file-maintenance

Conversation

renovate Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 4am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate Bot force-pushed the renovate/lock-file-maintenance branch from 1aa4626 to 04e02d6 Compare May 18, 2026 11:28

dbanty commented May 25, 2026

Copy link
Copy Markdown
Collaborator

@copilot can you update the code to get it working with mypy v2?

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor

@copilot can you update the code to get it working with mypy v2?

Done in commit 90afc56. Two changes were needed for mypy v2:

  1. end_to_end_tests/test_end_to_end.py: Replaced mypy.api.run() with subprocess.run([sys.executable, "-m", "mypy", ...]). mypy v2 is compiled with mypyc (.so files), which causes an ImportError: module 'mypy.main' is not in sys.modules when called in-process from within a pytest run.

  2. openapi_python_client/templates/literal_enum.py.jinja (+ 7 golden record files): Removed cast(Literal[...], value) from the generated check_* functions. mypy v2 now properly narrows the type of value to Literal[...] after an if value in set[Literal[...]] check, making the cast redundant (and flagging it as [redundant-cast]).

Copilot AI requested a review from dbanty May 25, 2026 19:26
Copilot finished work on behalf of dbanty May 25, 2026 19:26

renovate Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

dbanty changed the title chore(deps): lock file maintenance fix: Remove some generated casts that aren't necessary with mypy v2 May 25, 2026
dbanty added this pull request to the merge queue May 25, 2026
Merged via the queue into main with commit cc2ebc9 May 25, 2026
22 checks passed
dbanty deleted the renovate/lock-file-maintenance branch May 25, 2026 21:20
knope-bot Bot mentioned this pull request May 25, 2026
Merged
iloveitaly pushed a commit to iloveitaly/openapi-python-client that referenced this pull request May 31, 2026
Release 0.29.0 (openapi-generators#1439)
7939364 
> [!IMPORTANT]
> Merging this pull request will create this release

## Breaking Changes

- Drop support for Python 3.10
- Raise minimum httpx version to 0.23.1

## Features

- replace python-dateutil with stdlib datetime.fromisoformat (openapi-generators#1429)

## Fixes

- Remove some generated casts that aren't necessary with mypy v2 (openapi-generators#1436)
- Explicitly set boundary for multipart/form-data (openapi-generators#1005)

Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dbanty dbanty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL