Repository navigation
fix: prevent schema names from shadowing endpoint imports - #1490
Open
CodingCossack wants to merge 1 commit into
Open
CodingCossack wants to merge 1 commit into
CodingCossack wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Alias endpoint-owned Client, AuthenticatedClient, Response and HTTPStatus imports while preserving generated model names and public SDK types. Cover resolved annotations, request execution and response identities in functional tests, and update generated fixtures and release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1423.
Schemas named Client, AuthenticatedClient, Response or HTTPStatus can shadow imports in generated endpoints, producing incorrect annotations or broken response handling. Bind endpoint-owned SDK symbols and HTTPStatus through private aliases, preserving user model names and public SDK types.
Functional regressions check resolved annotations, public exports, synchronous and asynchronous requests, parsed model and response wrapper identities, status codes and authenticated endpoint signatures, with Customer as a non-collision control. The generated fixture changes follow directly from the template aliases; a patch changeset is included.
Validation: 474 tests and 5 snapshots passed, plus lint, formatting and mypy. All 64 changed generated endpoint files are AST-equivalent after reversing the aliases and normalising import grouping/order.