Repository navigation
switch from httpx to httpx2 - #1505
Closed
goodsonjr wants to merge 1 commit into
Closed
goodsonjr wants to merge 1 commit into
goodsonjr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Switches completely from httpx to httpx per openapi-generators#1455 Uses the 'import httpx2 as httpx' alias import and does not change the existing API. Makes minimal changes to the dependencies and lockfiles. Consumers of this package relying on the transitive httpx dependency will need to specify or migrate. The utilized version of httpx2 is API-compatible with httpx 0.28.1, any any future change to that can be dealt with when it happens.
Copy link
Copy Markdown
Collaborator
|
This is a clever approach, but I think long term it will be less confusing for users if we go all in on "httpx2" references as is done in |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks for the alternative! We did end up merging #1461 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches completely from httpx to httpx per #1455
I put this together before realizing there was #1461. I spent a while struggling with the lockfiles and the changes in recent ruff versions, but those were taken care of here. This does things slightly more minimally with an alias import and doesn't change the API to httpx2_-named methods, just relying on httpx2 being API-compatible with httpx 0.28.1. If that isn't desired, maybe this will be helpful for resolving the linting/testing issues in the other PR.