Let httpx2 choose the boundary for multipart/form-data requests
Since 0.29.0, generated endpoints sent every multipart/form-data body with the fixed boundary +++, so an uploaded file containing \r\n--+++ was cut short at that point (#1509). These bodies no longer set Content-Type, so httpx2 sets it with a random boundary for each request, as single-body endpoints did before 0.29.0. Endpoints with several body types still get a boundary (#947).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merging this pull request will create this release
❗️Breaking ❗
Switch from httpx to httpx2 in generated clients
httpx2 is largely compatible with httpx and should only be a breaking change for users who customize the internal Client.
Thanks to @s-sajid-ali and @johnthagen for making this one happen in PR #1461 and discussion #1455!
🚀 Features
🐛 Fixes
Let httpx2 choose the boundary for multipart/form-data requests
Since 0.29.0, generated endpoints sent every multipart/form-data body with the fixed boundary +++, so an uploaded file containing \r\n--+++ was cut short at that point (#1509). These bodies no longer set Content-Type, so httpx2 sets it with a random boundary for each request, as single-body endpoints did before 0.29.0. Endpoints with several body types still get a boundary (#947).