Repository navigation
fix: do not emit Unset for required multi-body endpoints (#1451) - #1517
Open
Rajan-vish wants to merge 1 commit into
Open
Rajan-vish wants to merge 1 commit into
Rajan-vish wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1451
When an endpoint has multiple bodies and the request body is required, the arguments macro in endpoint_macros.py.jinja was still appending | Unset = UNSET. This happened because body_required was not preserved across Jinja loop iterations with a namespace, leaving it undefined outside the loop.
This uses a Jinja namespace to track whether all bodies are required, and adds unit and functional tests covering the change.