FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support empty strings in enums by ramnes · Pull Request #358 · openapi-generators/openapi-python-client · GitHub

  1. openapi-generators
  2. openapi-python-client

Repository navigation

Support empty strings in enums #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbanty merged 1 commit into from
Mar 23, 2021
Conversation 2 Commits 1 Checks 0 Files changed
Merged

Support empty strings in enums #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion openapi_python_client/parser/properties/enum_property.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def values_from_list(values: List[ValueType]) -> Dict[str, ValueType]:
else:
output[f"VALUE_{value}"] = value
continue
if value[0].isalpha():
if value and value[0].isalpha():
key = value.upper()
else:
key = f"VALUE_{i}"
Expand Down
3 changes: 2 additions & 1 deletion tests/test_parser/test_properties/test_init.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def test_get_imports(self, mocker):
def test_values_from_list(self):
from openapi_python_client.parser.properties import EnumProperty

data = ["abc", "123", "a23", "1bc", 4, -3, "a Thing WIth spaces"]
data = ["abc", "123", "a23", "1bc", 4, -3, "a Thing WIth spaces", ""]

result = EnumProperty.values_from_list(data)

Expand All @@ -528,6 +528,7 @@ def test_values_from_list(self):
"VALUE_4": 4,
"VALUE_NEGATIVE_3": -3,
"A_THING_WITH_SPACES": "a Thing WIth spaces",
"VALUE_7": "",
}

def test_values_from_list_duplicate(self):
Expand Down
Back | FazBrowse Home | New Git URL