Allow overriding some more Makefile variables - #16
Merged
mcayland merged 1 commit intoApr 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Thanks! This looks good to me, so I've merged it. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This does not fix #15! This PR only allows overriding DESTDIR (and STRIP and CFLAGS, but that has nothing to do with #15). It still uses DESTDIR and PREFIX incorrectly. Please read the things I linked to in #15 (here's an updated link, as one of them appears to be broken): |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets anyone to override a few extra variables
Fixes #15.