| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by @bradenmacdonald. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information? If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #3250 +/- ##
========================================
Coverage 96.03% 96.03%
========================================
Files 1407 1407
Lines 34287 34302 +15
Branches 7882 8157 +275
========================================
+ Hits 32928 32943 +15
Misses 1318 1318
Partials 41 41 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Hi @jacobo-dominguez-wgu, thanks for handling this! I was testing it and everything works great for subsections and units. However, if I select a course section without Highlights, the 'Add Highlights' button remains enabled for Course Auditors
Can we fix this?
Sorry, something went wrong.
Fixed! Thanks for catching this! |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
|
@bradenmacdonald do you mind reviewing/merging this? |
Sorry, something went wrong.
@bradenmacdonald friendly reminder. |
Sorry, something went wrong.
|
Sorry @jacobo-dominguez-wgu , I have a huge backlog of PRs at the moment. But it really helps that @BryanttV and @dcoa have already reviewed this, so I won't worry about manually testing it myself in that case. |
Sorry, something went wrong.
No worries, thank you so much! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
This PR extends the canEditCourseContent permission gating to the section, subsection, and unit sidebar settings on the course outline page, so that users who can view a course but cannot edit its content see these settings in a read-only state instead of being able to change them.
Added unit tests to support modifications and created new unit tests files to increase code coverage.
User roles impacted
Supporting information
Addresses comment #3200 (comment)
Coses openedx/openedx-authz#383.
Figma: link
Testing instructions
Other information
View on section sidebar settings without canEditCourseContent permission

View on subsection sidebar settings without canEditCourseContent permission

View on unit sidebar without settings canEditCourseContent permission

Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review: