fix: modal size for lti content - #1787
Open
Faraz32123 wants to merge 2 commits into
Open
Faraz32123 wants to merge 2 commits into
Faraz32123 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- dialogClassName was working with Modal from paragon, but after paragon v23 upgrade. We replaced Modal with ModalDialog with which dialogClassName doesn't work. - So, replace dialogClassName with simple className to apply same styles.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1787 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 344 344
Lines 5792 5792
Branches 1331 1372 +41
=======================================
Hits 5261 5261
+ Misses 514 512 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
This was referenced Sep 9, 2025
Faraz32123
force-pushed
the
fix/modal_size_for_lti_content_upstream
branch
from
2b1b243 to
e66951c
Compare
September 9, 2025 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: COSMO2-716
Please review
paragon v22 Modal Props VS paragon ModalDialog Props API which used className instead of dialogClassName.