FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fetch exams data on the progress page by michaelroytman · Pull Request #1829 · openedx/frontend-app-learning · GitHub

Fetch exams data on the progress page - #1829

Merged
nsprenkle merged 2 commits into
openedx:masterfrom
edx:michaelroytman/AU-2692-with-hooks-progress-page-exam-grades-showing
Dec 15, 2025
Merged

nsprenkle merged 2 commits into
openedx:masterfrom
edx:michaelroytman/AU-2692-with-hooks-progress-page-exam-grades-showing

Conversation

Copy link
Copy Markdown
Contributor

Description

This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.

This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2025

Copy link
Copy Markdown

Thanks for the pull request, @michaelroytman!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

github-project-automation Bot moved this to Needs Triage in Contributions Nov 21, 2025
michaelroytman changed the title feat: fetch exams data on the progress page Fetch exams data on the progress page Nov 21, 2025
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.

This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.
michaelroytman force-pushed the michaelroytman/AU-2692-with-hooks-progress-page-exam-grades-showing branch from e19ed62 to d13e752 Compare November 21, 2025 12:42

codecov Bot commented Nov 21, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.18%. Comparing base (d0a8778) to head (3f50a73).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1829      +/-   ##
==========================================
+ Coverage   90.86%   91.18%   +0.31%     
==========================================
  Files         348      349       +1     
  Lines        5814     5831      +17     
  Branches     1341     1376      +35     
==========================================
+ Hits         5283     5317      +34     
+ Misses        514      495      -19     
- Partials       17       19       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nsprenkle self-requested a review November 21, 2025 17:23

nsprenkle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needs tests but is otherwise good to go 👍

itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Dec 4, 2025
itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Dec 4, 2025

itsjeyd commented Dec 4, 2025

Copy link
Copy Markdown

Hi @michaelroytman, thank you for this contribution!

I think it might require product review -- could you please double-check the criteria from Does my contribution require Product Review? and confirm?

Copy link
Copy Markdown
Contributor

Hi @michaelroytman, thank you for this contribution!

I think it might require product review -- could you please double-check the criteria from Does my contribution require Product Review? and confirm?

@itsjeyd, ith the current implementation, this just makes more data available to the page which can be consumed by anyone editing overriding the Progress Page, but not actually changing the default feature set. With that, I'd argue we're technically okay to go without Product Review.

itsjeyd moved this from Waiting on Author to In Eng Review in Contributions Dec 11, 2025

itsjeyd commented Dec 11, 2025

Copy link
Copy Markdown

@nsprenkle Thanks for clarifying 👍

@openedx/committers-frontend-app-learning This is ready for engineering review.

itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Dec 11, 2025
itsjeyd requested a review from a team December 11, 2025 11:04
nsprenkle merged commit 630e843 into openedx:master Dec 15, 2025
7 checks passed
nsprenkle deleted the michaelroytman/AU-2692-with-hooks-progress-page-exam-grades-showing branch December 15, 2025 20:18
github-project-automation Bot moved this from In Eng Review to Done in Contributions Dec 15, 2025
nsprenkle restored the michaelroytman/AU-2692-with-hooks-progress-page-exam-grades-showing branch December 15, 2025 20:20
nsprenkle added a commit to edx/frontend-app-learning that referenced this pull request Dec 15, 2025
* feat: fetch exams data on the progress page

This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.

This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.

---------

Co-authored-by: nsprenkle <nsprenkle@2u.com>
nsprenkle added a commit to edx/frontend-app-learning that referenced this pull request Dec 15, 2025
* feat: fetch exams data on the progress page

This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.

This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.

---------

Co-authored-by: nsprenkle <nsprenkle@2u.com>
nsprenkle added a commit to edx/frontend-app-learning that referenced this pull request Dec 17, 2025
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.

This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.

---------

Co-authored-by: nsprenkle <nsprenkle@2u.com>, Michael Roytman <mroytman@2u.com>
itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Dec 18, 2025
nsprenkle added a commit to edx/frontend-app-learning that referenced this pull request Dec 23, 2025
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.

This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.

---------

Co-authored-by: nsprenkle <nsprenkle@2u.com>, Michael Roytman <mroytman@2u.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL