| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks for the pull request, @michaelroytman! This repository is currently maintained by @openedx/committers-frontend-app-learning. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information? If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Sorry, something went wrong.
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade. This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1829 +/- ##
==========================================
+ Coverage 90.86% 91.18% +0.31%
==========================================
Files 348 349 +1
Lines 5814 5831 +17
Branches 1341 1376 +35
==========================================
+ Hits 5283 5317 +34
+ Misses 514 495 -19
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Needs tests but is otherwise good to go 👍
Sorry, something went wrong.
|
Hi @michaelroytman, thank you for this contribution! I think it might require product review -- could you please double-check the criteria from Does my contribution require Product Review? and confirm? |
Sorry, something went wrong.
@itsjeyd, ith the current implementation, this just makes more data available to the page which can be consumed by anyone editing overriding the Progress Page, but not actually changing the default feature set. With that, I'd argue we're technically okay to go without Product Review. |
Sorry, something went wrong.
|
@nsprenkle Thanks for clarifying 👍 @openedx/committers-frontend-app-learning This is ready for engineering review. |
Sorry, something went wrong.
* feat: fetch exams data on the progress page This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade. This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store. --------- Co-authored-by: nsprenkle <nsprenkle@2u.com>
* feat: fetch exams data on the progress page This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade. This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store. --------- Co-authored-by: nsprenkle <nsprenkle@2u.com>
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade. This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store. --------- Co-authored-by: nsprenkle <nsprenkle@2u.com>, Michael Roytman <mroytman@2u.com>
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade. This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store. --------- Co-authored-by: nsprenkle <nsprenkle@2u.com>, Michael Roytman <mroytman@2u.com>
| Back | FazBrowse Home | New Git URL |
Description
This commit adds changes to fetch the exams data associated with all subsections relevant to the progress page. Exams data is relevant to the progress page because the status of a learner's exam attempt may influence the state of their grade.
This allows children of the root ProgressPage or downstream plugin slots to access this data from the Redux store.