revert: sidebar widget registry refactor - #1898
Closed
arbrandes wants to merge 1 commit into
Closed
arbrandes wants to merge 1 commit into
arbrandes wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 93.47258% with 25 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 91.28% 91.16% -0.12%
==========================================
Files 343 349 +6
Lines 5770 5830 +60
Branches 1388 1348 -40
==========================================
+ Hits 5267 5315 +48
- Misses 484 498 +14
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Reverts the following two commits: - 59113b0 feat: move discussion topic prefetch from trigger to widget config lifecycle (openedx#1897) - 0664dc3 feat: decouple notifications panel using widget registry mechanism (openedx#1885) Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
revert-sidebar-refactor
branch
from
bf282da to
cd38f6b
Compare
April 16, 2026 20:31
Copy link
Copy Markdown
Contributor
Author
|
We ended up making the thing backward compatible instead. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts two recent commits that refactored the sidebar to use a widget registry mechanism (PRs #1885 and #1897):
This feature will have to be refactored with backward compatibility in mind.