FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: support design tokens and paragon 23 by dcoa · Pull Request #1173 · openedx/frontend-app-profile · GitHub

/ frontend-app-profile Public

feat: support design tokens and paragon 23 - #1173

Merged
brian-smith-tcril merged 3 commits into
openedx:master-design-tokensfrom
eduNEXT:dcoa/design-tokens-support
May 9, 2025
ConversationCommits (3)ChecksFiles changed
Merged

feat: support design tokens and paragon 23#1173
brian-smith-tcril merged 3 commits into
openedx:master-design-tokensfrom
eduNEXT:dcoa/design-tokens-support

Conversation

dcoa commented Feb 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description

This PR updates frontend app profile to support CSS variables and the corresponding paragon design tokens.

Changes implemented:

  • Replace Paragon SCSS variables with CSS variables.

Important

This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first:

How to test

  1. Use the current branch in the tutor environment
  2. Navigate to the Profile from the header user menu

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2025

openedx-webhooks commented Feb 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

github-project-automation Bot moved this to Needs Triage in Contributions Feb 27, 2025
dcoa mentioned this pull request Feb 27, 2025
Closed
mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 3, 2025
dcoa force-pushed the dcoa/design-tokens-support branch from 451ea51 to 9fbc2f4 Compare March 24, 2025 10:26
dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 24, 2025

codecov Bot commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (37feffc) to head (f54b198).
Report is 1 commits behind head on master-design-tokens.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           master-design-tokens    #1173   +/-   ##
=====================================================
  Coverage                 66.82%   66.82%           
=====================================================
  Files                        51       51           
  Lines                       856      856           
  Branches                    176      178    +2     
=====================================================
  Hits                        572      572           
  Misses                      273      273           
  Partials                     11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dcoa marked this pull request as ready for review March 26, 2025 02:11
dcoa requested a review from a team as a code owner March 26, 2025 02:11
dcoa requested a review from brian-smith-tcril March 26, 2025 02:12
dcoa force-pushed the dcoa/design-tokens-support branch from 9fbc2f4 to e84c98d Compare March 31, 2025 05:30
dcoa changed the title [WIP] feat: support design tokens and paragon 23 feat: support design tokens and paragon 23 Mar 31, 2025
dcoa force-pushed the dcoa/design-tokens-support branch from e84c98d to cf64142 Compare March 31, 2025 07:07
MaxFrank13 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 3, 2025
MaxFrank13 moved this to Blocked in Aperture-Maintained Apr 3, 2025

open-craft-grove commented Apr 4, 2025

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented Apr 7, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

dcoa force-pushed the dcoa/design-tokens-support branch from cf64142 to 4ecead5 Compare April 13, 2025 22:22

open-craft-grove commented Apr 13, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

dcoa force-pushed the dcoa/design-tokens-support branch from 4ecead5 to 53d0b5d Compare April 22, 2025 22:35

open-craft-grove commented Apr 23, 2025

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented Apr 23, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented Apr 23, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

dcoa force-pushed the dcoa/design-tokens-support branch from 53d0b5d to 2349d33 Compare April 28, 2025 02:17

open-craft-grove commented Apr 28, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

brian-smith-tcril reviewed May 8, 2025
View reviewed changes

brian-smith-tcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Once this is rebased this one is good to merge!

Comment thread src/profile/index.scss
.profile-page {
.edit-section-header {
@extend .h6;
font-size: var(--pgn-typography-font-size-h6-base);

brian-smith-tcril May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like this is another example of openedx/frontend-app-authn#1436 (comment)

Based on openedx/frontend-app-authn#1436 (comment) moving away from @extend in this way is good as-is!

dcoa force-pushed the dcoa/design-tokens-support branch from 2349d33 to f54b198 Compare May 9, 2025 00:41

dcoa commented May 9, 2025

Copy link
Copy Markdown
Contributor Author

@brian-smith-tcril rebased :)

open-craft-grove commented May 9, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

brian-smith-tcril changed the base branch from master to master-design-tokens May 9, 2025 16:01
brian-smith-tcril merged commit 747bd2f into openedx:master-design-tokens May 9, 2025
openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 9, 2025
github-project-automation Bot moved this from Waiting on Author to Done in Contributions May 9, 2025
github-project-automation Bot moved this from Blocked to Done in Aperture-Maintained May 9, 2025
brian-smith-tcril mentioned this pull request Sep 23, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brian-smith-tcril brian-smith-tcril approved these changes

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Aperture-Maintained
Status: Done
Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL