| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for the pull request, @dcoa! This repository is currently maintained by @openedx/committers-frontend. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information? If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 10 10
Lines 236 236
Branches 71 71
=======================================
Hits 226 226
Misses 9 9
Partials 1 1 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
|
Hi @brian-smith-tcril this PR is ready for review, I noticed that should be addressed first as been used in header and footer as dependency. Could you please review it before the other dependencies? |
Sorry, something went wrong.
There was a problem hiding this comment.
I've tested this locally against frontend-app-learner-dashboard by pulling this branch, building this branch using npm run build, and updating module.config.js in frontend-app-learner-dashboard to point to the dist directory of this branch for frontend-plugin-framework.
🎉 Everything seems to be working as expected! 🎉
@dcoa would you be OK with me using squash to merge this and changing the commit message from chore: to feat:? chore: commits don't kick off new releases, and we'll want to make sure a new version of frontend-plugin-framework is published when this lands.
Sorry, something went wrong.
|
Excellent @brian-smith-tcril, yes it is a good idea change the commit name and squash it during the merge |
Sorry, something went wrong.
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR updates frontend-plugin-framework with the compatibility for CSS Variables and Design Tokens, the new styling paradigm for the frontend.
Changes: