fix: example app render plugins and remove LMS authentication - #66
Merged
jsnwesson merged 2 commits intoMay 21, 2024
Merged
jsnwesson merged 2 commits into
jsnwesson merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* remove auth requirement for LMS * enables development outside of host devstack and LMS
Copy link
Copy Markdown
Member
Author
|
@bradenmacdonald @arbrandes @davidjoy this should be able to help close out #54 and make the example apps more available to the community! |
Sorry, something went wrong.
MaxFrank13
approved these changes
May 21, 2024
Copy link
Copy Markdown
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host example app was not able to render the plugins defined in env.config.js due to something to do with the frontend-component-header and frontend-component-footer dependencies living in the host's package.json (introduced in #61).
Although the reason is unclear of how they affected the configuration, we can safely remove them as they were unused by both example apps.
In addition, the hydrateAuthenticatedUser in Initialize is set to false so that the LMS isn't required to run the example apps, which will allow more from the open-source community to easily access the examples.
Steps to test (following steps in README for developers):