FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: example app render plugins and remove LMS authentication by jsnwesson · Pull Request #66 · openedx/frontend-plugin-framework · GitHub

/ frontend-plugin-framework Public

fix: example app render plugins and remove LMS authentication #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnwesson merged 2 commits into from
May 21, 2024
Conversation 2 Commits 2 Checks 0 Files changed
Merged

fix: example app render plugins and remove LMS authentication #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b359aea
refactor: remove footer and header deps in example apps
jsnwesson May 20, 2024
5025ac1
fix: rename plugin slot ids and remove datatest-id properties to clea…
jsnwesson May 21, 2024
File filter

Filter by extension

Filter by extension .json  (4) .jsx  (6) .scss  (1) All 3 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2,132 changes: 68 additions & 2,064 deletions example-plugin-app/package-lock.json
Show comments
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions example-plugin-app/package.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
"react": "^17.0.0",
"react-dom": "^17.0.0",
"react-router-dom": "^6.22.1",
"regenerator-runtime": "^0.14.1",
"@edx/frontend-component-footer": "14.0.0",
"@edx/frontend-component-header": "5.3.1"
"regenerator-runtime": "^0.14.1"
}
}
6 changes: 3 additions & 3 deletions example/env.config.jsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ const config = {
{
op: PLUGIN_OPERATIONS.Insert,
widget: {
id: 'inserted_direct_plugin',
id: 'insert_modular_direct_plugin',
type: DIRECT_PLUGIN,
priority: 1,
RenderWidget: ModularComponent,
Expand All @@ -149,7 +149,7 @@ const config = {
{
op: PLUGIN_OPERATIONS.Insert,
widget: {
id: 'inserted_direct_plugin',
id: 'insert_direct_plugin',
type: DIRECT_PLUGIN,
priority: 1,
RenderWidget: ModularComponent,
Expand All @@ -162,7 +162,7 @@ const config = {
{
op: PLUGIN_OPERATIONS.Insert,
widget: {
id: 'inserted_direct_plugin',
id: 'insert_another_direct_plugin',
type: DIRECT_PLUGIN,
priority: 10,
RenderWidget: PluginDirect,
Expand Down
3,759 changes: 1,511 additions & 2,248 deletions example/package-lock.json
Show comments
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions example/package.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@
"react-dom": "^17.0.0",
"react-router": "^6.22.3",
"react-router-dom": "^6.22.3",
"regenerator-runtime": "^0.14.1",
"@edx/frontend-component-footer": "14.0.0",
"@edx/frontend-component-header": "5.3.1"
"regenerator-runtime": "^0.14.1"
},
"devDependencies": {
"@openedx/frontend-build": "^14.0.3"
Expand Down
2 changes: 1 addition & 1 deletion example/src/index.jsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ subscribe(APP_INIT_ERROR, (error) => {
initialize({
messages: [],
requireAuthenticatedUser: false,
hydrateAuthenticatedUser: true,
hydrateAuthenticatedUser: false,
});
3 changes: 0 additions & 3 deletions example/src/index.scss
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,3 @@
@import "@edx/brand/paragon/variables.scss";
@import "@openedx/paragon/scss/core/core.scss";
@import "@edx/brand/paragon/overrides.scss";

@import "~@edx/frontend-component-header/dist/index";
@import "~@edx/frontend-component-footer/dist/footer";
1 change: 0 additions & 1 deletion example/src/pluginSlots/PluginSlotWithInsert.jsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ function PluginSlotWithInsert() {
<h2 className="pl-3">Plugin Operation: Insert</h2>
<PluginSlot
id="slot_with_insert_operation"
data-testid="testing"
>
<section className="bg-success p-3 text-light">
<h3>Default Content</h3>
Expand Down
1 change: 0 additions & 1 deletion example/src/pluginSlots/PluginSlotWithModifyWrapHide.jsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ function PluginSlotWithModifyWrapHide() {
<h2 className="pl-3">Plugin Operation: Modify, Wrap, and Hide</h2>
<PluginSlot
id="slot_with_modify_wrap_hidden_operations"
data-testid="testing"
>
<ModularComponent content={content}/>
</PluginSlot>
Expand Down
1 change: 0 additions & 1 deletion example/src/pluginSlots/PluginSlotWithModularPlugins.jsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ function PluginSlotWithModularPlugins() {
<h2 className="pl-3">Direct Plugins Using Modular Components</h2>
<PluginSlot
id="slot_with_modular_plugins"
data-testid="testing"
>
<ModularComponent content={content} />
</PluginSlot>
Expand Down
1 change: 0 additions & 1 deletion example/src/pluginSlots/PluginSlotWithoutDefault.jsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ function PluginSlotWithoutDefault() {
<h2 className="pl-3">Default Content Set to False</h2>
<PluginSlot
id="slot_without_default"
data-testid="testing"
>
</PluginSlot>
</div>
Expand Down
Back | FazBrowse Home | New Git URL