FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: [AA-1207] remove redundant Tabs fields from courseware API by cdeery · Pull Request #30023 · openedx/openedx-platform · GitHub

/ openedx-platform Public

feat: [AA-1207] remove redundant Tabs fields from courseware API - #30023

Merged
cdeery merged 2 commits into
masterfrom
cdeery/AA-1207/RemoveExtraTabsBackend
Mar 11, 2022
ConversationCommits (2)ChecksFiles changed
Merged

feat: [AA-1207] remove redundant Tabs fields from courseware API#30023
cdeery merged 2 commits into
masterfrom
cdeery/AA-1207/RemoveExtraTabsBackend

Conversation

cdeery commented Mar 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

All the tab information now goes through the course home metadata tab fields. This field is redundant.

These are the backend changes to support openedx/frontend-app-learning#861

These changes only impact the backend to the learning MFE BFF.

feat: [AA-1207] remove redundant Tabs fields from courseware API
ed05096 
All the tab information now goes through the course home metadata tab fields. This field is redundant.
cdeery mentioned this pull request Mar 7, 2022
Merged
mikix approved these changes Mar 8, 2022
View reviewed changes

mikix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Dillon-Dumesnil approved these changes Mar 8, 2022
View reviewed changes

Dillon-Dumesnil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Was there a swagger.yml doc that also needs to be updated? I remember that from the other PRs.
Are there other fields that are supposed to be done in this ticket or are they coming in other PRs?

cdeery merged commit 50f348b into master Mar 11, 2022
cdeery deleted the cdeery/AA-1207/RemoveExtraTabsBackend branch March 11, 2022 14:36

edx-pipeline-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

edx-pipeline-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

brian-smith-tcril mentioned this pull request Sep 22, 2026
Merged
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
mikix mikix approved these changes
Dillon-Dumesnil Dillon-Dumesnil approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL