FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Fix unit tests failing with release branch env variable by mgwozdz-unicon · Pull Request #38497 · openedx/openedx-platform · GitHub

/ openedx-platform Public

fix: Fix unit tests failing with release branch env variable - #38497

Merged
wgu-taylor-payne merged 3 commits into
openedx:masterfrom
mgwozdz-unicon:fix-unit-tests-failing-for-release-branch
May 1, 2026
ConversationCommits (3)ChecksFiles changed
Merged

fix: Fix unit tests failing with release branch env variable#38497
wgu-taylor-payne merged 3 commits into
openedx:masterfrom
mgwozdz-unicon:fix-unit-tests-failing-for-release-branch

Conversation

mgwozdz-unicon commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Description

My Verawood PR has unit tests failing on what appears to be an unrelated environment variable issue:

FAILED lms/djangoapps/mfe_config_api/tests/test_views.py::MFEConfigTestCase::test_legacy_overrides_instructor_dashboard - AssertionError: 'https://docs.openedx.org/en/open-release-verawood.master/educators/index.html' != 'https://docs.openedx.org/en/latest/educators/index.html'
- https://docs.openedx.org/en/open-release-verawood.master/educators/index.html
?                             ^^ ---------------------  --
+ https://docs.openedx.org/en/latest/educators/index.html
?                             ^^^
FAILED lms/djangoapps/mfe_config_api/tests/test_views.py::FrontendSiteConfigTestCase::test_legacy_overrides_instructor_dashboard_support_url - AssertionError: 'https://docs.openedx.org/en/open-release-verawood.master/educators/index.html' != 'https://docs.openedx.org/en/latest/educators/index.html'
- https://docs.openedx.org/en/open-release-verawood.master/educators/index.html
?                             ^^ ---------------------  --
+ https://docs.openedx.org/en/latest/educators/index.html
?                             ^^^

Supporting information

This is blocking getting #38495 into the Verawood release.

Testing instructions

python -m pytest lms/djangoapps/mfe_config_api/tests/test_views.py

Deadline

This is blocking getting #38495 into the Verawood release.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 30, 2026

openedx-webhooks commented Apr 30, 2026

Copy link
Copy Markdown

Thanks for the pull request, @mgwozdz-unicon!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

github-project-automation Bot moved this to Needs Triage in Contributions Apr 30, 2026
wgu-taylor-payne reviewed Apr 30, 2026
View reviewed changes

wgu-taylor-payne left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The fix makes sense — the hardcoded "latest" breaks on release branches where doc_version() returns "open-release-verawood.master".

How the URL is constructed

The SUPPORT_URL flows through four layers:

  1. View layer — views.py: get_legacy_config_overrides() calls resolve_help_token("instructor") → HelpUrlExpert.the_one().url_for_token("instructor")
  2. help-tokens library — url_for_token() reads help_tokens.ini (instructor = course_author:index.html), looks up HELP_TOKENS_BOOKS["course_author"], then replaces /latest with /{version}
  3. Settings — common.py: HELP_TOKENS_VERSION = Derived(lambda settings: doc_version())
  4. Release info — release.py: doc_version() returns "latest" on master, "open-release-{RELEASE_LINE}.master" on release branches

See inline suggestion for a slightly more precise alternative approach.

Review assisted by Kiro

Comment thread lms/djangoapps/mfe_config_api/tests/test_views.py Outdated
wgu-taylor-payne approved these changes May 1, 2026
View reviewed changes

wgu-taylor-payne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks for this! Do you plan to make a backport PR for this @mgwozdz-unicon?

wgu-taylor-payne enabled auto-merge (squash) May 1, 2026 00:34
wgu-taylor-payne merged commit d327dd3 into openedx:master May 1, 2026
41 checks passed
github-project-automation Bot moved this from Needs Triage to Done in Contributions May 1, 2026
brian-smith-tcril mentioned this pull request May 1, 2026
Closed
2 tasks
feanil mentioned this pull request May 1, 2026
Closed

feanil commented May 1, 2026

Copy link
Copy Markdown
Contributor

Backport PR for verawood: #38503

feanil pushed a commit that referenced this pull request May 1, 2026
fix: make mfe_config_api tests portable across release branches (#38497)
8adbabb 
(cherry picked from commit d327dd3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wgu-taylor-payne wgu-taylor-payne approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL