FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add scroll to modal content when fullscreen (#38859) by navinkarkera · Pull Request #38893 · openedx/openedx-platform · GitHub

/ openedx-platform Public

fix: add scroll to modal content when fullscreen (#38859) - #38893

Merged
ChrisChV merged 1 commit into
openedx:release/verawoodfrom
open-craft:navin/fal-4369/verawood/fix-modal-scroll
Jul 16, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix: add scroll to modal content when fullscreen (#38859)#38893
ChrisChV merged 1 commit into
openedx:release/verawoodfrom
open-craft:navin/fal-4369/verawood/fix-modal-scroll

Conversation

navinkarkera commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Studio modal doesn't allow authors to scroll when content is longer than the screen height, so this commit adds a max-height based on screen height.

(cherry picked from commit c82accb)

Backport of #38859

fix: add scroll to modal content when fullscreen (openedx#38859)
0d937b7 
Studio modal doesn't allow authors to scroll when content is longer than the screen height, so this commit adds a max-height based on screen height.

(cherry picked from commit c82accb)
openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 15, 2026

openedx-webhooks commented Jul 15, 2026

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

github-project-automation Bot moved this to Needs Triage in Contributions Jul 15, 2026

navinkarkera commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@farhaanbukhsh FYI

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jul 15, 2026
Kelketek requested a review from ChrisChV July 15, 2026 18:42

ChrisChV commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@navinkarkera I tested this on a Verawood instance with the coding-eval-xblock. It does let me scroll, but the modal's footer hides the last field.

navinkarkera commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@ChrisChV I am not able to reproduce it. Have you updated your xblock-ai-evaluation repository with latest opencraft/ulmo branch? We need the changes from this PR: open-craft/xblock-ai-evaluation#53

ChrisChV commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I am not able to reproduce it. Have you updated your xblock-ai-evaluation repository with latest opencraft/ulmo branch? We need the changes from this PR: open-craft/xblock-ai-evaluation#53

You are right! Sorry. Looks good 👍

ChrisChV approved these changes Jul 16, 2026
View reviewed changes

ChrisChV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

  • I tested this: I tested the changes in a verawood instance
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).

ChrisChV merged commit 553df2b into openedx:release/verawood Jul 16, 2026
42 checks passed
ChrisChV deleted the navin/fal-4369/verawood/fix-modal-scroll branch July 16, 2026 18:09
github-project-automation Bot moved this from Waiting on Author to Done in Contributions Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ChrisChV ChrisChV approved these changes

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL