Improve DictionaryProperty.Read/Write encoding - #421
Merged
jeremy-visionaid merged 1 commit intoApr 22, 2026
Merged
jeremy-visionaid merged 1 commit into
jeremy-visionaid merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…once Instead of once per property. As there are multiple properties, and all have the same code page, we can call Encoding.GetEncoding once and use it for all the properties, rather than calling GetEncoding per property. This actually gives a measurable performance increase when reading DocumentSummaryInformation property streams with UserDefined properties.
Copy link
Copy Markdown
Contributor
Author
|
We could probably do something similar with the reading of LPSTR properties, but that's not so self contained so that's just a future thought. |
Sorry, something went wrong.
This was referenced May 18, 2026
Open
This was referenced May 19, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…once
Instead of once per property.
As there are multiple properties, and all have the same code page, we can call Encoding.GetEncoding once and use it for all the properties, rather than calling GetEncoding per property.
This actually gives a measurable performance increase when reading DocumentSummaryInformation property streams with UserDefined properties.
This was an observation whilst doing #420 that I noticed when I changed a Unicode case to always use Encoding.Unicode instead of calling Encoding.GetEncoding and it got faster (GetEncoding appears to do some internal locking that we can skip by only doing it once, at least when all the additional code pages have been registered in PropertyFactory)
I currently get these benchmark results with the main branch:
But after this change I get
The Unicode case gets a bigger difference because the test file contains more properties.
Seems worth doing though when it's quite simple.