Convert PropertyIdentifierAndOffset to a record struct - #422
Merged
jeremy-visionaid merged 1 commit intoApr 27, 2026
Merged
jeremy-visionaid merged 1 commit into
jeremy-visionaid merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Instances are immutable (they're never modified after creation), so being a record seems reasonable and makes things a tad simpler.
jeremy-visionaid
approved these changes
Apr 27, 2026
jeremy-visionaid
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I agree it should be a record struct. Minor nit that the commit message is incorrect since records and record structs are different
Sorry, something went wrong.
This was referenced May 18, 2026
Open
This was referenced May 19, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instances are immutable (they're never modified after creation), so being a record seems reasonable and makes things a tad simpler.
Just a little bit of musing on things when testing other changes.
I initially just made it a record to make it immutable, but then ran the benchmarks being a struct does save a little bit of memory -
Before:
After:
Open for comments on it being a struct or a class. There are similar things in the core library that are structs for reference though.