Fix the handling of missing CodePage properties - #428
Merged
jeremy-visionaid merged 1 commit intoMay 3, 2026
Merged
jeremy-visionaid merged 1 commit into
jeremy-visionaid merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ntext And add a new unit test for the property being missing. I apparently broke this when PropertyIdentifierAndOffset was made a struct, as FirstOrDefault returns an empty value instead of null when its missing, which caused it to think the property exists with an offset of zero. This fixes that by using FindIndex instead of FirstOrDefault, and also adds a new test file which has no codepage property present, and a new unit test which tests that reading the summary information from that file results in the expected error.
Copy link
Copy Markdown
Contributor
Author
|
I hit this when updating https://github.com/openmcdf/openmcdf/pull/407/changes, where there are no code pages in the HWP documents |
Sorry, something went wrong.
This was referenced May 18, 2026
Open
This was referenced May 19, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntext
And add a new unit test for the property being missing.
I apparently broke this when PropertyIdentifierAndOffset was made a struct, as FirstOrDefault returns an empty value instead of null when its missing, which caused it to think the property exists with an offset of zero.
This fixes that by using FindIndex instead of FirstOrDefault, and also adds a new test file which has no codepage property present, and a new unit test which tests that reading the summary information from that file results in the expected error.
(None of the existing tests caught this because all of them have a code page property present)