[BUG] Temporarily fix issue #1544 by marking the failed tests as expected fail. - #1572
Merged
fkiraly merged 4 commits intoDec 29, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
EmanAbdelhaleem
marked this pull request as ready for review
December 29, 2025 18:02
fkiraly
approved these changes
Dec 29, 2025
fkiraly
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks! Quick-merging to restore CI to working order.
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files @@ Coverage Diff @@
## main #1572 +/- ##
===========================================
- Coverage 85.24% 63.91% -21.33%
===========================================
Files 38 36 -2
Lines 5008 4351 -657
===========================================
- Hits 4269 2781 -1488
- Misses 739 1570 +831 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
fkiraly
pushed a commit
that referenced
this pull request
Dec 31, 2025
….8, 3.9 after EOL, marking further failing tests as `xfail` (#1579) The CI runs only on python versions 3.8 and 3.9 both of which have already reached end of life. This PR updates the python versions, deprecating any logic that runs tests on python versions 3.8 and 3.9, or `scikit-learn` versions of that age. #### Metadata Reference Issue: #1544 Depends on #1584 fofr a fix, which should be merged first. #### Details * The test matrix is updated to python versions, 3.10-3.13. * Further failing tests are skipped using `mark.xfail` with `reason="failures_issue_1544" ` for all the remaining failed tests (after #1572) in issue: #1544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary skip for all test failures to enable work on the repository
Metadata
Details