Ported several functions missed out from fixes.inc. - #663
Merged
AmyrAhmady merged 1 commit intoJun 8, 2023
Merged
AmyrAhmady merged 1 commit into
AmyrAhmady merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…e trivial as the data already existed in the server: * `GetDefaultPlayerColour` - just a wrapper for a newly abstracted `PlayerPool::getDefaultColour` function. * `GetVehicleSeats` - wraps `getVehiclePassengerSeats`. * `VehicleCanHaveComponent` - wraps `isValidComponentForVehicleModel`. * `IsValidAnimationLibrary` - wraps `animationLibraryValid`, including an optional second parameter (default `true`). * `PlayerHasClockEnabled` - wraps `player.hasClock`. Although the server also missed `IsMenuValid` it has `IsValidMenu` instead, though that doesn't fix the syntax pattern on the other `IsMenuXXX` functions. I'll leave this fix to includes for now, we can maybe think about updating the server later.
Copy link
Copy Markdown
|
Alex Cole seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sorry, something went wrong.
Zorono
reviewed
May 21, 2023
Comment thread
Server/Components/Pawn/Scripting/Player/Natives.cpp
| return true; | ||
| } | ||
|
|
||
| SCRIPT_API(PlayerHasClockEnabled, bool(IPlayer& player)) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
i suggest that function name can be changed to IsPlayerClockEnabled
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
The names are lifted straight from old includes.
Sorry, something went wrong.
AmyrAhmady
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these were trivial as the data already existed in the server:
Although the server also missed IsMenuValid it has IsValidMenu instead, though that doesn't fix the syntax pattern on the other IsMenuXXX functions. I'll leave this fix to includes for now, we can maybe think about updating the server later.