CVS-190150_nginx_update_urllib3 - #4380
Open
ngrozae wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the nginx mTLS auth helper script to generate a localhost server certificate that includes a Subject Alternative Name (SAN), addressing stricter hostname verification behavior (e.g., clients using urllib3 >= 2 that no longer rely on CN alone).
Changes:
- Add SAN (DNS:localhost and IP:127.0.0.1) to the self-signed server certificate generated by openssl req -x509.
- Improve compatibility with modern TLS client validation that requires SAN for hostname/IP matching.
Sorry, something went wrong.
Comment thread
extras/nginx-mtls-auth/generate_certs.sh
| echo "WARNING: For development and testing only. Please follow your organization security practices on handling and distribution of cryptography material." | ||
| echo "====================================================================================================================================================" | ||
| openssl req -x509 -nodes -days 1 -newkey rsa:4096 -keyout server.key -out server.pem -subj "/C=US/CN=localhost" | ||
| openssl req -x509 -nodes -days 1 -newkey rsa:4096 -keyout server.key -out server.pem -subj "/C=US/CN=localhost" -addext "subjectAltName=DNS:localhost,IP:127.0.0.1" |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
OpenSSL 1.0.2 and 1.1.0 had end of life in 2019. Comment is not relevant in our case.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-190150 - nginx update for urllib3 > 2
🧪 Checklist
``