Small changes for mindtouch - #213
Merged
benoit74 merged 2 commits intoNov 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #213 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 2223 2224 +1
Branches 426 426
=========================================
+ Hits 2223 2224 +1 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
benoit74
marked this pull request as ready for review
November 8, 2024 13:05
rgaudin
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very simplified version of #211 since for now decided not to include an executor but rely on joblib (or another parallel processing lib) for now.
Changes: