refactor: simplify handling of reused event sources - #1518
Merged
csviri merged 6 commits intoOct 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
metacosm
force-pushed
the
use-es-instead-do-not-provide
branch
from
705e9a5 to
22e7d92
Compare
October 4, 2022 15:05
metacosm
approved these changes
Oct 4, 2022
csviri
commented
Oct 5, 2022
Comment thread
...n/java/io/javaoperatorsdk/operator/api/reconciler/dependent/DeferrableEventSourceHolder.java
Outdated
|
|
||
| default void useEventSourceWithName(String name) {} | ||
|
|
||
| Optional<String> resolveEventSource(EventSourceRetriever<P> eventSourceRetriever); |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
This Optional part feels a little weird to me. IMO should rather throw something like EventSourceNotFoundException.
What do you think?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
It does not have to be even collected, since this will always fail to start the operator, and needs code change. So it is not even a config error if an exception is thrown here.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Yeah, it's a little awkward. I'd like to collect it because, as a user, I prefer to know all the mistakes I made at once if possible instead of failing, fixing one thing only to have an error on another thing and fail again…
Sorry, something went wrong.
metacosm
approved these changes
Oct 5, 2022
Copy link
Copy Markdown
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, something went wrong.
csviri
added a commit
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
metacosm
added a commit
that referenced
this pull request
Oct 7, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 19, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 19, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 21, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 21, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 25, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.