FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

improve: metrics processing e2e test stability by csviri · Pull Request #3244 · operator-framework/java-operator-sdk · GitHub

improve: metrics processing e2e test stability - #3244

Merged
csviri merged 2 commits into
operator-framework:mainfrom
csviri:fix-metrics-e2e-webhook
Mar 19, 2026
Merged

improve: metrics processing e2e test stability#3244
csviri merged 2 commits into
operator-framework:mainfrom
csviri:fix-metrics-e2e-webhook

Conversation

csviri commented Mar 19, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Copilot AI review requested due to automatic review settings March 19, 2026 09:01
openshift-ci Bot requested review from metacosm and xstefank March 19, 2026 09:01
csviri marked this pull request as draft March 19, 2026 09:02
openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR improves the stability of the metrics processing e2e tests by addressing race conditions that occur when creating OpenTelemetry Collector resources. The issue arises because the OpenTelemetry Operator's webhook may not be fully ready immediately after the deployment becomes available, causing custom resource creations to fail.

Changes:

  • Added a wait for the OpenTelemetry Operator deployment to be ready before proceeding with resource creation
  • Implemented retry logic (20 attempts with 5-second intervals) when creating the OpenTelemetry Collector to handle webhook startup delays
  • Enhanced status messaging to indicate retry attempts and webhook readiness issues

You can also share your feedback on Copilot code review. Take the survey.

Comment thread observability/install-observability.sh Outdated
csviri and others added 2 commits March 19, 2026 10:04
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
csviri force-pushed the fix-metrics-e2e-webhook branch from 4850f6a to 492c233 Compare March 19, 2026 09:04
csviri marked this pull request as ready for review March 19, 2026 09:14
openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2026
csviri linked an issue Mar 19, 2026 that may be closed by this pull request

csviri commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator Author

@metacosm @xstefank this seems stabilizes the end to end test. I've run it few times now.

csviri merged commit 1a07a04 into operator-framework:main Mar 19, 2026
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The metrics processing flaky E2E test because of OTel collector startup

3 participants


Back | FazBrowse Home | New Git URL