fix: handling delete non-active dependent when parent reconcile condition false - #3273
Merged
csviri merged 9 commits intoApr 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…tion false Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
marked this pull request as ready for review
April 7, 2026 12:26
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of deleting non-active dependents when parent reconciliation conditions are false, and improves the event source management for activation conditions. The changes introduce a condition result caching mechanism to optimize condition evaluation and refactor the deletion logic for better clarity.
Changes:
- Added condition result caching to avoid redundant evaluations within a single reconciliation cycle
- Refactored deletion handling to check activation conditions at execution time rather than during marking phase
- Enhanced InformerEventSource with a guard clause to prevent starting an already-running event source
- Added test coverage for event source registration/deregistration behavior with activation conditions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| WorkflowReconcileExecutorTest.java | Added EventSourceRetriever mock and three new test cases for activation condition event source management |
| InformerEventSource.java | Added guard clause in start() method to prevent redundant starts |
| WorkflowReconcileExecutor.java | Refactored deletion logic and removed activation condition parameter from handleReconcileOrActivationConditionNotMet |
| AbstractWorkflowExecutor.java | Added condition result caching in isConditionMet() method |
| BaseWorkflowResult.java | Added getConditionResult() method to support condition caching |
Sorry, something went wrong.
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Apr 8, 2026
k-wall
reviewed
Apr 8, 2026
Comment thread
...java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutor.java
Outdated
k-wall
reviewed
Apr 8, 2026
Comment thread
...atorsdk/operator/workflow/preconditionandactivation/PreconditionAndActivationReconciler.java
Outdated
dongjoon-hyun
added a commit
to apache/spark-kubernetes-operator
that referenced
this pull request
Apr 10, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `operator-sdk` to 5.3.3. ### Why are the changes needed? To bring the latest bug fixes of Java Operator SDK. - https://github.com/operator-framework/java-operator-sdk/releases/tag/v5.3.3 - operator-framework/java-operator-sdk#3273 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.6 Closes #628 from dongjoon-hyun/SPARK-56433. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com