improve: eager informer start check - #3275
Merged
csviri merged 1 commit intoApr 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
this is important for dynamic event source registration to not reindex resources Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the eager start check in the InformerEventSource class to prevent unnecessary re-indexing of resources during dynamic event source registration. The change adds an early return guard in the start() method that checks if the event source is already running before proceeding with resource initialization.
Changes:
- Added an early return check in InformerEventSource.start() to prevent the re-indexing operation when the event source is already running
Sorry, something went wrong.
xstefank
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is important for dynamic event source registration to not reindex resources
Signed-off-by: Attila Mészáros a_meszaros@apple.com