Pull request overview

This PR updates the Maven project/module versions across Java Operator SDK and its submodules, presumably in preparation for the next development cycle.

Changes:

• Bumped the root project version in pom.xml.
• Updated all module parent version references to match the new root version.
• Updated the standalone operator-framework-bom artifact version.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 17 comments.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

pom.xml:24

• The project version was changed to 999-SNAPSHOT, which will publish/build artifacts under an unexpected version and doesn't align with the stated v5.5 line. Revert to the previous snapshot version (or the intended next v5.5.x version).

  <version>999-SNAPSHOT</version>

operator-framework-core/pom.xml:24

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

operator-framework/pom.xml:24

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

operator-framework-junit/pom.xml:24

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

operator-framework-bom/pom.xml:24

• The BOM version was changed to 999-SNAPSHOT, which will publish an unexpected BOM coordinate/version. Revert to the previous snapshot version (or the intended next v5.5.x version).

  <version>999-SNAPSHOT</version>

migration/pom.xml:24

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

micrometer-support/pom.xml:24

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

caffeine-bounded-cache-support/pom.xml:24

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

bootstrapper-maven-plugin/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this plugin resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

test-index-processor/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this module resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make the samples aggregator resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/webpage/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this sample resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/tomcat-operator/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this sample resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/operations/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this sample resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/mysql-schema/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this sample resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/leader-election/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this sample resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

sample-operators/controller-namespace-deletion/pom.xml:25

• The parent version was changed to 999-SNAPSHOT, which will make this sample resolve against an unexpected parent version. Revert to the previous snapshot version (or the intended next v5.5.x version).

    <version>999-SNAPSHOT</version>

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

pom.xml:24

• Project version is set to 999-SNAPSHOT, which doesn’t align with the PR title targeting v5.6 and looks like a placeholder version. This will publish artifacts under an unexpected coordinate; set the intended next snapshot version (e.g., 5.6.0-SNAPSHOT) and keep all module parent versions consistent with it.

  <version>999-SNAPSHOT</version>

operator-framework/pom.xml:24

• Module parent version is set to 999-SNAPSHOT. If the intent is v5.6, this should match the root project version (e.g., 5.6.0-SNAPSHOT) to avoid producing/publishing modules under an unexpected version.

    <version>999-SNAPSHOT</version>

operator-framework-bom/pom.xml:24

• BOM version is set to 999-SNAPSHOT, which appears to be a placeholder and doesn’t match the PR’s v5.6 intent. Use the intended snapshot version (e.g., 5.6.0-SNAPSHOT) so consumers don’t import an unexpected BOM version.

  <version>999-SNAPSHOT</version>

Pull request overview

Copilot reviewed 88 out of 88 changed files in this pull request and generated no new comments.

pom.xml:25

• The project version is set to 999-SNAPSHOT, which doesn’t match the PR title indicating a v5.6 branch and will produce artifacts with an unexpected coordinate. If this is intended to be the next development snapshot, use a 5.6.x-SNAPSHOT version (and keep all module parent versions aligned).
  operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java:34
• Use the generic diamond operator here to avoid a raw ConcurrentHashMap (this currently forces @SuppressWarnings({"unchecked", "rawtypes"}) to cover more than necessary).

  private final Map<ClassifierWithName, SharedIndexInformer> informers = new ConcurrentHashMap();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java:502

• ConfigurationService#informerPool() currently returns a new DefaultInformerPool instance on every call and doesn’t call setConfigurationService(this), which violates the method’s own contract (“same instance on every call”) and can disable cross-controller informer sharing (or break reference counting) for implementations that don’t override it. Consider caching and initializing the pool in the default implementation (or make it non-default and require implementations to provide a cached pool).

  @Experimental(
      "Only the configuration API around informer pooling could still change in a"
          + " non-backwards-compatible way, the pooling itself is prod ready.")
  default InformerPool informerPool() {
    return new DefaultInformerPool();

Pull request overview

Copilot reviewed 106 out of 106 changed files in this pull request and generated 1 comment.

pom.xml:25

• The root project version is set to 999-SNAPSHOT, which doesn’t match the PR title intent ("next (v5.6; …)") and will cause all produced artifacts to use an obviously placeholder version. Please set this to the intended next snapshot version and keep it consistent across all module parent references updated in this PR.
  operator-framework-core/pom.xml:26
• This module now points at parent version 999-SNAPSHOT, which looks like a placeholder and will prevent aligning the module with the actual reactor parent version intended for the v5.6 line. Please update to the real parent snapshot version (and keep consistent with the root pom.xml).

  <parent>
    <groupId>io.javaoperatorsdk</groupId>
    <artifactId>java-operator-sdk</artifactId>
    <version>999-SNAPSHOT</version>
    <relativePath>../pom.xml</relativePath>
  </parent>

sample-operators/pom.xml:26

• The sample-operators parent version is set to 999-SNAPSHOT, which appears to be a placeholder and should match the actual parent version used by the root project for the intended release line.

Pull request overview

Copilot reviewed 106 out of 106 changed files in this pull request and generated no new comments.

pom.xml:24

• Setting the root project version to 999-SNAPSHOT looks like a placeholder rather than a real next development version. This will change published Maven coordinates (including the BOM) and can break downstream consumers and release tooling; if the intent is a regular version bump, it should use the correct semantic version and remain consistent across all child POM parent versions.
  operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java:491
• The Javadoc requires informerPool() to return the same instance on every call, but the current default implementation constructs a new DefaultInformerPool each time. Any ConfigurationService implementation relying on the default method will silently disable informer sharing and can break reference-counting / release symmetry across different call sites.

   * <p><strong>Implementations must return the same instance on every call.</strong> The pool is
   * effectively a per-{@code ConfigurationService} singleton: controllers share informers only if
   * they resolve the same pool, and reference counting / informer shutdown are only correct if
   * {@code getInformer} and {@code releaseInformer} operate on that same instance. This is
   * intentionally not a {@code default} method, since a {@code default} could not cache the result

Actionable comments posted: 10

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java (1)

76-84: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove assertion-restating comments.

The assertions already state the required behavior. Keep comments only for very long or complex logic.

• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java#L76-L84: Remove the comments before the size and status-ID assertions.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowIT.java#L83-L93: Remove the equivalent comments before the size and status-ID assertions.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java`
around lines 76 - 84, Remove the assertion-restating comments in
ExternalStateInStatusIT.java (lines 76-84) and
ExternalStateInStatusWorkflowIT.java (lines 83-93), specifically those preceding
the resource-size and status-ID assertions. Leave the assertions and test
behavior unchanged.

Source: Coding guidelines

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java (1)

18-18: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove the unnecessary Javadocs from the simple status models.

• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java#L18-L18: Remove the Javadoc.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusStatus.java#L18-L18: Remove the Javadoc.

As per coding guidelines, “Do not add comments except for very long or complex logic.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java`
at line 18, Remove the unnecessary Javadoc above ExternalStateInStatusStatus in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java:18-18
and
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusStatus.java:18-18;
leave the simple status model declarations unchanged.

Source: Coding guidelines

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java (1)

79-79: 📐 Maintainability & Code Quality | 🔵 Trivial

Track the deprecation TODO.

// todo deprecate marks unfinished API work on a public interface method. Do you want me to open an issue to track deprecating getGroupVersionKind()?

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java`
at line 79, Track the planned deprecation of the public interface method
getGroupVersionKind() by creating an issue or equivalent project-tracking item,
and retain the existing TODO marker until that work is formally tracked.

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java (1)

42-58: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider copying fields so the new hash code stays stable.

FieldSelector is now used inside InformerClassifier, which is a HashMap key in DefaultInformerPool. The constructors store the caller's list without a copy, so a later mutation of that list changes hashCode() and makes the pooled informer unreachable by its own key. A defensive copy in the constructors removes that risk and matches the "prefer immutable objects" guideline.

As per coding guidelines: "Prefer immutable objects where possible."

♻️ Proposed change (outside the reviewed range)

public FieldSelector(List<Field> fields) {
  this.fields = List.copyOf(fields);
}

public FieldSelector(Field... fields) {
  this.fields = List.of(fields);
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java`
around lines 42 - 58, Update both FieldSelector constructors to defensively copy
their inputs: use an immutable list copy for the List<Field> constructor and an
immutable varargs list for the Field... constructor. Ensure the stored fields
cannot be mutated after construction, keeping equals, hashCode, and toString
unchanged.

Source: Coding guidelines

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java (1)

176-186: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Protect the original startup failure from a failing cleanup.

If manager().stop() throws while releasing the already-acquired pooled informers, its exception replaces the real startup failure and the caller loses the root cause. Add the cleanup failure as a suppressed exception.

♻️ Proposed change

     try {
       manager().start();
     } catch (RuntimeException e) {
       // The manager acquires a pooled informer for every watched namespace before any of them is
       // started, so a startup failure has to hand those references back here: super.start() is not
       // reached, which leaves isRunning() false and makes stop() skip the release entirely. The
       // pooled informer would then be referenced forever (never stopped, even on a clean shutdown)
       // and a retried start() would acquire it a second time.
-      manager().stop();
+      try {
+        manager().stop();
+      } catch (RuntimeException cleanupFailure) {
+        e.addSuppressed(cleanupFailure);
+      }
       throw e;
     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java`
around lines 176 - 186, Update the RuntimeException catch in
ManagedInformerEventSource startup so manager().stop() cleanup failures are
added as suppressed exceptions to the original startup exception, then rethrow
the original exception. Preserve cleanup execution and the existing startup
behavior.

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java (1)

57-67: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Synchronize releaseInformer to match getInformer and DefaultInformerPool.

getInformer holds the instance monitor across the containsKey/create/put sequence. releaseInformer mutates the same map without that monitor. If a release and an acquisition for the same key overlap, the release can remove and stop an informer that the acquisition just published and returned. DefaultInformerPool.releaseInformer is synchronized, so the two pool implementations also expose different locking contracts today.

🔒 Proposed fix

   `@Override`
-  public <R extends HasMetadata> Optional<SharedIndexInformer<R>> releaseInformer(
+  public synchronized <R extends HasMetadata> Optional<SharedIndexInformer<R>> releaseInformer(
       String controllerName, String name, InformerClassifier<R> classifier) {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java`
around lines 57 - 67, Synchronize NonSharingInformerPool.releaseInformer on the
same instance monitor used by getInformer, covering the informer removal, stop,
logging, and return flow. Match DefaultInformerPool’s locking contract so
release cannot race with acquisition for the same key.

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java (1)

24-24: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove redundant Javadocs from simple test types and variants.

These comments do not describe very long or complex logic.

• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java#L24-L24: Remove the model Javadoc.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSharedInformerIT.java#L22-L22: Remove the variant Javadoc.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterWatchedCustomResource.java#L24-L27: Remove the model Javadoc.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/NonSharingInformerPoolDeregisterSharedInformerIT.java#L23-L27: Remove the variant Javadoc.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource1.java#L24-L24: Remove the model Javadoc.
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/NonSharingInformerPoolDynamicSharedInformerIT.java#L23-L28: Remove the variant Javadoc.

As per coding guidelines, do not add comments except for very long or complex logic.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java`
at line 24, Remove the redundant Javadocs from the simple test types and
variants in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java:24,
DeregisterSharedInformerIT.java:22, DeregisterWatchedCustomResource.java:24-27,
NonSharingInformerPoolDeregisterSharedInformerIT.java:23-27, and
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource1.java:24
and NonSharingInformerPoolDynamicSharedInformerIT.java:23-28; leave the type and
test implementations unchanged and do not add replacement comments.

Source: Coding guidelines

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/content/en/docs/documentation/eventing.md`:
- Around line 358-364: Update the informer-pool description around “informer
pool” and “SharedIndexInformer” to explicitly limit sharing to controllers and
event sources within the same Operator instance/configuration service; clarify
that separate Operator instances or processes do not share informers.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java`:
- Around line 483-503: Change ConfigurationService.informerPool() from a default
method to an abstract method by removing its DefaultInformerPool construction
and configuration logic. Keep the existing cached implementation in
AbstractConfigurationService unchanged so every configuration service returns
the same pool instance.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java`:
- Around line 55-63: Update the deprecated InformerEventSource constructor
Javadoc to link with {`@link`
`#InformerEventSource`(InformerEventSourceConfiguration)}. In the constructor path
identified by InformerEventSource and InformerManager, preserve and propagate
context.getClient() instead of discarding the EventSourceContext, ensuring
deprecated callers use their configured client rather than the
ConfigurationService fallback.

In
`@operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/GroupVersionKindTest.java`:
- Around line 105-106: Remove the explanatory comment near the GroupVersionKind
equality test, leaving the test name and assertions unchanged.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/AbstractSharedInformerIT.java`:
- Around line 63-83: Update bothControllersReconcileWatchingConfigMap to record
each reconciler’s execution count after the initial resources are created, then
create or update the watched ConfigMap and await assertions that both
SharedInformerReconciler1 and SharedInformerReconciler2 execution counts
increase. Keep the existing readiness checks and use the ConfigMap fixture/API
already established by the test.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/NonSharingInformerPoolSharedInformerIT.java`:
- Around line 23-26: Remove the redundant comments: delete the class Javadoc and
inline count comment in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/NonSharingInformerPoolSharedInformerIT.java
lines 23-26; delete the class Javadoc and default-pool inline comment in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerIT.java
lines 22-25; delete the class Javadoc in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerIT.java
lines 22-25; and delete the redundant Javadoc in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource2.java
line 24. Do not add replacement comments.

In `@README.md`:
- Line 69: Update the project descriptions in README.md: add “is an” to the
Apache Spark Kubernetes Operator entry, remove the conflicting “While ... but”
construction in the entries around lines 75–76, change the line 80 wording to
“not yet released as open source,” and hyphenate “cloud-native” on line 81.

In `@sample-operators/kotlin-operator/k8s/operator.yaml`:
- Around line 53-71: Update the ClusterRole rules in operator.yaml: remove the
customresourcedefinitions rule, limit configmapcopies to informer read verbs
plus status patching, and replace the configmaps wildcard with only the verbs
required for server-side apply.
- Around line 27-32: Update the operator Pod specification around the
serviceAccountName and operator container to define explicit Pod and container
security contexts: enforce non-root execution, set the RuntimeDefault seccomp
profile, drop all capabilities, disable privilege escalation, and use a
read-only root filesystem. If the JVM requires writable temporary storage, add
an emptyDir volume mounted only at the required temporary path.
- Around line 39-41: Update the ServiceAccount subject in the subjects
configuration to include its namespace, using the namespace where the
kotlin-operator ServiceAccount and Pod are created.

---

Outside diff comments:
In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java`:
- Around line 111-136: Update InformerManager.changeNamespaces and stop to use
one shared lifecycle lock and stopped state. Under that lock, serialize source
lookup, acquisition, insertion, removal, and shutdown so additions cannot start
after stop and concurrent namespace changes cannot acquire duplicate sources;
ensure additions are rejected or released once stopped. Add a race test covering
stop() concurrent with adding a namespace.

---

Nitpick comments:
In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java`:
- Around line 42-58: Update both FieldSelector constructors to defensively copy
their inputs: use an immutable list copy for the List<Field> constructor and an
immutable varargs list for the Field... constructor. Ensure the stored fields
cannot be mutated after construction, keeping equals, hashCode, and toString
unchanged.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java`:
- Line 79: Track the planned deprecation of the public interface method
getGroupVersionKind() by creating an issue or equivalent project-tracking item,
and retain the existing TODO marker until that work is formally tracked.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java`:
- Around line 176-186: Update the RuntimeException catch in
ManagedInformerEventSource startup so manager().stop() cleanup failures are
added as suppressed exceptions to the original startup exception, then rethrow
the original exception. Preserve cleanup execution and the existing startup
behavior.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java`:
- Around line 57-67: Synchronize NonSharingInformerPool.releaseInformer on the
same instance monitor used by getInformer, covering the informer removal, stop,
logging, and return flow. Match DefaultInformerPool’s locking contract so
release cannot race with acquisition for the same key.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java`:
- Around line 76-84: Remove the assertion-restating comments in
ExternalStateInStatusIT.java (lines 76-84) and
ExternalStateInStatusWorkflowIT.java (lines 83-93), specifically those preceding
the resource-size and status-ID assertions. Leave the assertions and test
behavior unchanged.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java`:
- Line 18: Remove the unnecessary Javadoc above ExternalStateInStatusStatus in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java:18-18
and
operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusStatus.java:18-18;
leave the simple status model declarations unchanged.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java`:
- Line 24: Remove the redundant Javadocs from the simple test types and variants
in
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java:24,
DeregisterSharedInformerIT.java:22, DeregisterWatchedCustomResource.java:24-27,
NonSharingInformerPoolDeregisterSharedInformerIT.java:23-27, and
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource1.java:24
and NonSharingInformerPoolDynamicSharedInformerIT.java:23-28; leave the type and
test implementations unchanged and do not add replacement comments.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0eebf96a-6321-4144-877c-743406646182

Reviewing files that changed from the base of the PR and between eb978f9 and 592bad3.

• .github/workflows/e2e-test.yml
• README.md
• bootstrapper-maven-plugin/pom.xml
• caffeine-bounded-cache-support/pom.xml
• docs/content/en/docs/documentation/eventing.md
• micrometer-support/pom.xml
• migration/pom.xml
• operator-framework-bom/pom.xml
• operator-framework-core/pom.xml
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperations.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/GroupVersionKind.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GroupVersionKindPlural.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutor.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/EventFilterWindow.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/AbstractInformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerClassifier.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/MockKubernetesClient.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperationsTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/ControllerTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/GroupVersionKindTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/EventSourceManagerTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcherTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSourceTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSourceTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManagerConcurrentReleaseTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapperTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceNamespaceChangeTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourcePoolIdentityTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceStartFailureTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPoolTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerClassifierTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPoolTest.java
• operator-framework-core/src/test/kotlin/io/javaoperatorsdk/operator/processing/dependent/workflow/KotlinCheckedExceptionDependentResourceTest.kt
• operator-framework-junit/pom.xml
• operator-framework-junit/src/main/java/io/javaoperatorsdk/operator/junit/LocallyRunOperatorExtension.java
• operator-framework/pom.xml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/AbstractSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/NonSharingInformerPoolSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerCustomResource1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerCustomResource2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/AbstractDeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterWatchedCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/NonSharingInformerPoolDeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/AbstractDynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerThirdCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/NonSharingInformerPoolDynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/StaticSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/ResourceOperationsIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/ResourceOperationsReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/triggerallevent/eventing/TriggerReconcilerOnAllEventIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusDependentResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/standalonedependent/StandaloneDependentResourceIT.java
• pom.xml
• sample-operators/controller-namespace-deletion/pom.xml
• sample-operators/kotlin-operator/README.md
• sample-operators/kotlin-operator/k8s/operator.yaml
• sample-operators/kotlin-operator/pom.xml
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopy.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyOperator.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyReconciler.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopySpec.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyStatus.kt
• sample-operators/kotlin-operator/src/main/resources/log4j2.xml
• sample-operators/kotlin-operator/src/test/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyE2E.kt
• sample-operators/kotlin-operator/src/test/resources/log4j2.xml
• sample-operators/leader-election/pom.xml
• sample-operators/mysql-schema/pom.xml
• sample-operators/operations/pom.xml
• sample-operators/pom.xml
• sample-operators/tomcat-operator/pom.xml
• sample-operators/webpage/pom.xml
• test-index-processor/pom.xml

Actionable comments posted: 1

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java`:
- Line 491: Wrap the Javadoc sentence near ConfigurationService so the line
stays within 100 characters, moving the {`@link` AbstractConfigurationService}
reference to the following Javadoc line without changing the text or meaning.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e9863ae-539b-4cd5-8514-627b967d93ad

Reviewing files that changed from the base of the PR and between eb978f9 and 592bad3.

• .github/workflows/e2e-test.yml
• README.md
• bootstrapper-maven-plugin/pom.xml
• caffeine-bounded-cache-support/pom.xml
• docs/content/en/docs/documentation/eventing.md
• micrometer-support/pom.xml
• migration/pom.xml
• operator-framework-bom/pom.xml
• operator-framework-core/pom.xml
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperations.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/GroupVersionKind.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GroupVersionKindPlural.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutor.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/EventFilterWindow.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/AbstractInformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerClassifier.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/MockKubernetesClient.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperationsTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/ControllerTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/GroupVersionKindTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/EventSourceManagerTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcherTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSourceTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSourceTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManagerConcurrentReleaseTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapperTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceNamespaceChangeTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourcePoolIdentityTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceStartFailureTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPoolTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerClassifierTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPoolTest.java
• operator-framework-core/src/test/kotlin/io/javaoperatorsdk/operator/processing/dependent/workflow/KotlinCheckedExceptionDependentResourceTest.kt
• operator-framework-junit/pom.xml
• operator-framework-junit/src/main/java/io/javaoperatorsdk/operator/junit/LocallyRunOperatorExtension.java
• operator-framework/pom.xml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/AbstractSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/NonSharingInformerPoolSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerCustomResource1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerCustomResource2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/AbstractDeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterWatchedCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/NonSharingInformerPoolDeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/AbstractDynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerThirdCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/NonSharingInformerPoolDynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/StaticSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/ResourceOperationsIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/ResourceOperationsReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/triggerallevent/eventing/TriggerReconcilerOnAllEventIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusDependentResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/standalonedependent/StandaloneDependentResourceIT.java
• pom.xml
• sample-operators/controller-namespace-deletion/pom.xml
• sample-operators/kotlin-operator/README.md
• sample-operators/kotlin-operator/k8s/operator.yaml
• sample-operators/kotlin-operator/pom.xml
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopy.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyOperator.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyReconciler.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopySpec.kt
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyStatus.kt
• sample-operators/kotlin-operator/src/main/resources/log4j2.xml
• sample-operators/kotlin-operator/src/test/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyE2E.kt
• sample-operators/kotlin-operator/src/test/resources/log4j2.xml
• sample-operators/leader-election/pom.xml
• sample-operators/mysql-schema/pom.xml
• sample-operators/operations/pom.xml
• sample-operators/pom.xml
• sample-operators/tomcat-operator/pom.xml
• sample-operators/webpage/pom.xml
• test-index-processor/pom.xml

• sample-operators/controller-namespace-deletion/pom.xml
• test-index-processor/pom.xml
• operator-framework-junit/src/main/java/io/javaoperatorsdk/operator/junit/LocallyRunOperatorExtension.java
• sample-operators/pom.xml
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
• operator-framework/pom.xml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerCustomResource1.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/GroupVersionKind.java
• operator-framework-bom/pom.xml
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutor.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/NonSharingInformerPoolDeregisterSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSpec.java
• docs/content/en/docs/documentation/eventing.md
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSource.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/EventSourceManagerTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/ResourceOperationsIT.java
• sample-operators/operations/pom.xml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/NonSharingInformerPoolDynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/standalonedependent/StandaloneDependentResourceIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterWatchedCustomResource.java
• migration/pom.xml
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManagerConcurrentReleaseTest.java
• sample-operators/webpage/pom.xml
• operator-framework-core/src/test/kotlin/io/javaoperatorsdk/operator/processing/dependent/workflow/KotlinCheckedExceptionDependentResourceTest.kt
• sample-operators/kotlin-operator/src/test/resources/log4j2.xml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusIT.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerClassifierTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourcePoolIdentityTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusStatus.java
• sample-operators/mysql-schema/pom.xml
• sample-operators/leader-election/pom.xml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/AbstractSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/AbstractDynamicSharedInformerIT.java
• bootstrapper-maven-plugin/pom.xml
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopy.kt
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapperTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource1.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/MockKubernetesClient.java
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopySpec.kt
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterReconciler.java
• sample-operators/tomcat-operator/pom.xml
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyStatus.kt
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerStatus.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/AbstractDeregisterSharedInformerIT.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterPrimaryCustomResource.java
• sample-operators/kotlin-operator/src/main/resources/log4j2.xml
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPoolTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusSpec.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowCustomResource.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceStartFailureTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerPrimaryCustomResource2.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/EventFilterWindow.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java
• .github/workflows/e2e-test.yml
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerThirdCustomResource.java
• operator-framework-junit/pom.xml
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GroupVersionKindPlural.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/GroupVersionKindTest.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerClassifier.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterSharedInformerIT.java
• sample-operators/kotlin-operator/src/test/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyE2E.kt
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerCustomResource2.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPoolTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/NonSharingInformerPoolSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/ResourceOperationsReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerReconciler.java
• pom.xml
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceNamespaceChangeTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/triggerallevent/eventing/TriggerReconcilerOnAllEventIT.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/ControllerTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSourceTest.java
• sample-operators/kotlin-operator/pom.xml
• micrometer-support/pom.xml
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyReconciler.kt
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusWorkflowIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusDependentResource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstateinstatus/ExternalStateInStatusStatus.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerPool.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperationsTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/externalstateinstatus/ExternalStateInStatusReconciler.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/NonSharingInformerPool.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java
• sample-operators/kotlin-operator/src/main/kotlin/io/javaoperatorsdk/operator/sample/ConfigMapCopyOperator.kt
• sample-operators/kotlin-operator/README.md
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/StaticSharedInformerReconciler.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler1.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSourceTest.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperations.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/AbstractInformerPool.java
• operator-framework-core/pom.xml
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcherTest.java
• caffeine-bounded-cache-support/pom.xml

Actionable comments posted: 1

operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/ConfigMapDependentResource.java (1)

39-46: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use var for these non-short local declarations.

• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/ConfigMapDependentResource.java#L39-L46: Change ConfigMap configMap to var configMap.
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentConverterTest.java#L86-L93: Change the ControllerConfiguration and ConfigurationService locals to var.
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceApiVersionChangeTest.java#L287-L298: Change the Context and ControllerConfiguration locals to var.

As per coding guidelines, “Prefer var over explicit type declarations except for short types such as int, long, and String.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/ConfigMapDependentResource.java`
around lines 39 - 46, Replace the non-short explicit local type declarations
with var at all affected sites: ConfigMapDependentResource.java lines 39-46 for
configMap, KubernetesDependentConverterTest.java lines 86-93 for the
ControllerConfiguration and ConfigurationService locals, and
KubernetesDependentResourceApiVersionChangeTest.java lines 287-298 for the
Context and ControllerConfiguration locals. Leave short types such as String
unchanged.

Source: Coding guidelines

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/DetectApiVersionChangeReconciler.java`:
- Around line 20-21: Replace the wildcard import from
io.javaoperatorsdk.operator.api.reconciler in DetectApiVersionChangeReconciler
with explicit named imports for each reconciler API class referenced in the
file, while retaining simple class names and the existing Dependent import.

---

Nitpick comments:
In
`@operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/ConfigMapDependentResource.java`:
- Around line 39-46: Replace the non-short explicit local type declarations with
var at all affected sites: ConfigMapDependentResource.java lines 39-46 for
configMap, KubernetesDependentConverterTest.java lines 86-93 for the
ControllerConfiguration and ConfigurationService locals, and
KubernetesDependentResourceApiVersionChangeTest.java lines 287-298 for the
Context and ControllerConfiguration locals. Leave short types such as String
unchanged.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 26077978-c224-4816-b647-d1c91970527e

Reviewing files that changed from the base of the PR and between 592bad3 and d4bd3da.

• docs/content/en/docs/documentation/dependent-resource-and-workflows/dependent-resources.md
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependent.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentConverter.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfig.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfigBuilder.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentConverterTest.java
• operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceApiVersionChangeTest.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/ConfigMapDependentResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/DetectApiVersionChangeCustomResource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/DetectApiVersionChangeIT.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/detectapiversionchange/DetectApiVersionChangeReconciler.java

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Informable.java (2)

36-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Confirm that the new Javadoc is allowed.

Lines 36-39 add comments to a short method. This conflicts with the rule that comments should only describe very long or complex logic. Remove the block unless public API Javadocs are explicitly exempted.

As per coding guidelines, **/*.java: Do not add comments except for very long or complex logic.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Informable.java`
around lines 36 - 39, Remove the newly added Javadoc block associated with the
Informable method, since it documents a short method and violates the Java
comment guideline; leave the method and surrounding API unchanged.

Source: Coding guidelines

---

40-42: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add coverage for both Kubernetes client selection paths.

Test the default Optional.empty() behavior and a custom Optional<KubernetesClient>. Assert that InformerManager selects the custom client and otherwise uses the controller configuration client.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Informable.java`
around lines 40 - 42, Add tests covering Informable.getKubernetesClient()
returning Optional.empty() and a custom Optional<KubernetesClient>. Verify that
InformerManager uses the custom client when provided and falls back to the
controller configuration client when absent.

Source: Coding guidelines

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Informable.java`:
- Around line 36-39: Remove the newly added Javadoc block associated with the
Informable method, since it documents a short method and violates the Java
comment guideline; leave the method and surrounding API unchanged.
- Around line 40-42: Add tests covering Informable.getKubernetesClient()
returning Optional.empty() and a custom Optional<KubernetesClient>. Verify that
InformerManager uses the custom client when provided and falls back to the
controller configuration client when absent.

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 34b82110-8f2e-494c-9025-e89921bfc387

Reviewing files that changed from the base of the PR and between d4bd3da and b5022e2.

• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Informable.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java

• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java

• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcher.java (1)

226-248: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add regression tests for both sanitization branches.

The helper now exits when actual and desired volumeClaimTemplates counts differ. Add or verify tests for:

• Equal counts with omitted volumeMode and status.
• Different counts with no sanitization and a non-match result.

Verify the adjacent SSABasedGenericKubernetesResourceMatcherTest coverage:

#!/bin/bash
set -euo pipefail

test_file="operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcherTest.java"
rg -n -C 4 'volumeClaimTemplates|volumeMode|status' "$test_file"

As per coding guidelines, **/*.{java,xml} files require unit and/or integration tests for new functionality whenever reasonably possible.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcher.java`
around lines 226 - 248, Add regression coverage in
SSABasedGenericKubernetesResourceMatcherTest for equal-sized
volumeClaimTemplates where omitted volumeMode and status are sanitized, and for
differing sizes where sanitization is skipped and matching returns false. Reuse
the existing matcher test setup and assert both branches through the public
matching behavior.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcher.java`:
- Around line 226-248: Add regression coverage in
SSABasedGenericKubernetesResourceMatcherTest for equal-sized
volumeClaimTemplates where omitted volumeMode and status are sanitized, and for
differing sizes where sanitization is skipped and matching returns false. Reuse
the existing matcher test setup and assert both branches through the public
matching behavior.

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a0f9eb21-dc75-4b5c-8555-9cb631e63bb6

Reviewing files that changed from the base of the PR and between b5022e2 and 484727d.

• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcher.java

Actionable comments posted: 1

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/content/en/docs/documentation/operations/configuration.md`:
- Line 87: Update the documentation example using
withNamespacesInheritedFromController() to call the builder method without the
obsolete context argument, while preserving the surrounding configuration chain
and build() call.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0edfdbb5-0760-43f0-bcca-14fc8185e5f2

Reviewing files that changed from the base of the PR and between 484727d and 51490a2.

• caffeine-bounded-cache-support/src/test/java/io/javaoperatorsdk/operator/processing/event/source/cache/sample/AbstractTestReconciler.java
• docs/content/en/docs/documentation/event-filters.md
• docs/content/en/docs/documentation/eventing.md
• docs/content/en/docs/documentation/operations/configuration.md
• docs/content/en/docs/documentation/working-with-es-caches.md
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/changenamespace/ChangeNamespaceTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/clusterscopedresource/ClusterScopedCustomResourceReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/dynamicgenericeventsourceregistration/DynamicGenericEventSourceRegistrationReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/expectation/onallevent/ExpectationReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/expectation/periodicclean/PeriodicCleanerExpectationReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/fieldselector/FieldSelectorTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/filter/FilterTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/generickubernetesresourcehandling/GenericKubernetesResourceHandlingReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informereventsource/InformerEventSourceTestCustomReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler2.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/StaticSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerremotecluster/InformerRemoteClusterReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/latestdistinct/LatestDistinctTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/multiplesecondaryeventsource/MultipleSecondaryEventSourceReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ownerreferencemultiversion/OwnerRefMultiVersionReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/primaryindexer/PrimaryIndexerTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/primarytosecondary/JobReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/externalsecondaryupdate/ExternalSecondaryUpdateReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/onrelistfilter/OnRelistFilterReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/ownsecondaryupdate/OwnSecondaryUpdateReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/readownupdates/ReadOwnUpdatesReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/resourceoperations/SecondaryResourceOperationsReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/secondarytoprimaryreferencechange/TargetReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/simple/TestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/startsecondaryaccess/StartupSecondaryAccessReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstate/ExternalStateDependentReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstate/ExternalStateReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstate/externalstatebulkdependent/ExternalStateBulkDependentReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipledependentresource/MultipleDependentResourceReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipledependentresourcewithsametype/MultipleDependentResourceWithDiscriminatorReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multipledrsametypenodiscriminator/MultipleManagedDependentSameTypeNoDiscriminatorReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/multiplemanageddependentsametype/MultipleManagedDependentResourceReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/primaryindexer/DependentPrimaryIndexerTestReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/primarytosecondaydependent/PrimaryToSecondaryDependentReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/complexdependent/ComplexWorkflowReconciler.java
• sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java
• sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java

• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler2.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
• docs/content/en/docs/documentation/eventing.md
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/basic/SharedInformerReconciler1.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/DynamicSharedInformerReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/deregister/DeregisterReconciler.java
• operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/informerpool/dynamic/StaticSharedInformerReconciler.java
• operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java