fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506) by carlos-alm · Pull Request #1540 · optave/ops-codegraph-tool · GitHub

Summary

Fixes 6 of 12 remaining jelly-micro parity divergences from issue #1506. Three root causes addressed:

resolveThisDispatch same-file preference: When super.m() resolves to a parent class that exists under the same name in multiple files (e.g. class A defined in super.js, super2.js, and super4.js), only same-file nodes are returned. All three call sites now pass callerFile (relPath).
CHA double-expansion guard: runChaPostPass and runPostNativeCha now exclude edges with technique='cha' from BFS expansion. A super-dispatch edge (PostMixin.m → A.m) was being re-expanded via CHA implementors to produce false PostMixin.m → B.m edges at CHA_TYPED_DISPATCH_CONFIDENCE=0.8.
Func-prop this-dispatch in native post-pass: runPostNativeThisDispatch was restricted to files in the extends hierarchy. Files with func-prop method definitions like f.h = function(){ this.g(); } (where f is not a class) were excluded. Added a UNION sub-query that includes files where method-node owner prefixes are not known class names, fixing this/this.js:f.h → f.g in the native engine.

Results

Before: 12 parity diffs
After:   5 parity diffs (6 fixed, 5 filed as issues)

Remaining 5 diffs filed as:

fix(native): object literal method callee naming — native uses o1.f(function), WASM uses f(method) #1538: Native engine uses o1.f(function) vs WASM's f(method) for object literal shorthand methods (Rust fix required)
fix: false cross-file receiver edges for function-constructor pattern (prototypes.js C → wrong class) #1539: Both engines pick the wrong cross-file C class for constructor-function receiver edges (prototypes.js)

Test plan

npm test — all 180 test files pass (3048 tests)
node scripts/parity-compare.mjs --langs jelly-micro — 5 diffs (down from 12)
npx vitest run tests/benchmarks/resolution/resolution-benchmark.test.ts — 176 tests pass

Closes #1506

…#1506) Three root causes fixed: 1. resolveThisDispatch: prefer same-file method nodes when callerFile is provided. When super-dispatch finds parent class A in multiple files (name collision), only same-file A.m nodes are returned. All three call sites updated to pass relPath. 2. runChaPostPass / runPostNativeCha: exclude already-resolved CHA edges (technique='cha') from BFS expansion. Super-dispatch edges pointing to A.m must not be re-expanded to B.m implementors — that produces false cross-file polymorphic dispatch edges. 3. runPostNativeThisDispatch: extend relFiles to include files with func-prop method definitions (e.g. f.h = function(){this.g()}) that are not in the extends hierarchy. Filters to method nodes whose owner prefix is not a known class name, keeping the added set small. Fixes 6 of 12 jelly-micro parity diffs. Remaining 5 filed as #1538, #1539.

Greptile Summary

This PR eliminates 6 of 12 remaining jelly-micro parity divergences by addressing three independent root causes: a same-file preference in resolveThisDispatch to suppress cross-fixture false super.m() edges, a CHA double-expansion guard (technique != 'cha') applied consistently to runChaPostPass, runPostNativeCha, and both query sites inside those functions, and a new UNION sub-query in runPostNativeThisDispatch that includes func-prop files in the native post-pass re-parse set.

resolveThisDispatch same-file preference (cha.ts): when identical class names exist across multiple files, same-file method nodes are preferred; AND name IS NOT NULL in the inner NOT-IN sub-select correctly prevents silent NULL-propagation failures.
CHA double-expansion guard (helpers.ts, native-orchestrator.ts): AND (e.technique IS NULL OR e.technique != 'cha') added to all three edge-selection queries, preventing super-dispatch CHA edges from being re-expanded via implementors BFS to produce spurious sibling edges.
Func-prop native post-pass (native-orchestrator.ts): new UNION branch adds files whose dot-named method owners are not known class/struct/interface/type names, letting runPostNativeThisDispatch resolve this.g() calls inside f.h = function(){} bodies.

Confidence Score: 5/5

The three fixes are narrowly scoped post-pass additions that do not alter primary parsing or storage paths, making this safe to merge.

All changed files touch post-pass logic running after core edge insertion. The CHA double-expansion guard is a well-understood SQL filter applied symmetrically. The same-file preference falls back to previous behaviour when no same-file node exists. The NULL guard in the inner NOT IN sub-select was explicitly added. Remaining observations are speculative edge cases in pathological codebases.

cha.ts — the same-file preference applies across all BFS iterations, not just the starting class; worth revisiting if cross-file inheritance combined with class-name collisions appears in real-world projects beyond test fixtures.

Important Files Changed

Filename	Overview
src/domain/graph/builder/cha.ts	Adds optional callerFile parameter to resolveThisDispatch; when same-file method nodes exist in the result set, only those are returned — preventing cross-file false edges from class-name collisions across fixture files.
src/domain/graph/builder/helpers.ts	Adds AND (e.technique IS NULL OR e.technique != 'cha') guard to runChaPostPass so edges already inserted by a CHA pass are not re-expanded via BFS, eliminating duplicate false edges.
src/domain/graph/builder/stages/build-edges.ts	Threads relPath into both resolveThisDispatch call sites so the new same-file preference in cha.ts is activated for the WASM/JS path.
src/domain/graph/builder/stages/native-orchestrator.ts	Three changes: double-expansion guard added to both runPostNativeCha query sites; func-prop UNION branch added with correct AND name IS NOT NULL guard; relPath passed to resolveThisDispatch. The incremental path bypasses the UNION query, consistent with the existing NOTE comment.

Sequence Diagram

sequenceDiagram
    participant Native as Native Rust Engine
    participant CHA as runPostNativeCha
    participant TD as runPostNativeThisDispatch
    participant RTD as resolveThisDispatch

    Native->>CHA: "edges (kind=calls, technique!=cha)"
    Note over CHA: technique!='cha' guard prevents BFS re-expansion
    CHA->>CHA: BFS over implementors
    CHA-->>Native: "new CHA edges (technique='cha')"
    Native->>TD: trigger after CHA
    TD->>TD: "relFiles = extends-hierarchy UNION func-prop files"
    TD->>TD: WASM re-parse relFiles
    TD->>RTD: resolveThisDispatch(..., relPath)
    Note over RTD: same-file preference on found nodes
    RTD-->>TD: filtered targets
    TD-->>Native: "new this/super dispatch edges (technique='cha')"

Reviews (5): Last reviewed commit: "fix: resolve merge conflicts with main" | Re-trigger Greptile

NOT IN with potential NULL names silences the entire UNION branch

The inner subquery SELECT name FROM nodes WHERE kind IN ('class', 'struct', 'interface', 'type') may return rows whose name is NULL (e.g. an anonymous class or a parser-produced node with no identifier). In SQL, x NOT IN (NULL, ...) evaluates to NULL, which is falsy in a WHERE clause, so every outer row is silently rejected. If that happens, the UNION branch emits zero rows and the func-prop feature is completely non-functional — with no error or warning. Adding AND name IS NOT NULL to the inner SELECT prevents this.

Suggested change

      
                      AND SUBSTR(n.name, 1, INSTR(n.name, '.') - 1) NOT IN (
          
                        SELECT name FROM nodes WHERE kind IN ('class', 'struct', 'interface', 'type')
          
                      )
          
                      AND SUBSTR(n.name, 1, INSTR(n.name, '.') - 1) NOT IN (
          
                        SELECT name FROM nodes WHERE kind IN ('class', 'struct', 'interface', 'type') AND name IS NOT NULL
          
                      )

Fixed — AND name IS NOT NULL is already applied to the inner sub-select (line 802). The guard was added in commit cd5c9875 alongside a comment explaining the SQL NULL semantics (lines 793–794). No anonymous-class node can silently suppress the entire UNION branch.

Codegraph Impact Analysis

6 functions changed → 10 callers affected across 5 files

resolveThisDispatch in src/domain/graph/builder/cha.ts:108 (8 transitive callers)
runChaPostPass in src/domain/graph/builder/helpers.ts:389 (3 transitive callers)
buildChaPostPass in src/domain/graph/builder/stages/build-edges.ts:683 (3 transitive callers)
buildFileCallEdges in src/domain/graph/builder/stages/build-edges.ts:991 (3 transitive callers)
runPostNativeCha in src/domain/graph/builder/stages/native-orchestrator.ts:423 (4 transitive callers)
runPostNativeThisDispatch in src/domain/graph/builder/stages/native-orchestrator.ts:714 (4 transitive callers)

…-dispatch

Addressed both issues:

NOT IN NULL hazard: Added AND name IS NOT NULL to the class-kind sub-select in the UNION arm, so a NULL name never silently suppresses all func-prop file results.
Early-exit guard unreachability: Already fixed in main (fix(native): resolve this-dispatch in func-prop methods (#1512) #1536) which widened the guard to if (!hasExtends && !hasFuncPropMethod) return and removed the parents.size === 0 bail-out. These changes will be incorporated when the merge conflict with main is resolved.

Note: this PR currently has a content conflict with main (both #1536 and this PR modified native-orchestrator.ts). Conflict resolution is pending.

@greptileai

docs check acknowledged

…ethod files docs check acknowledged

greptile-apps Bot reviewed Jun 14, 2026

View reviewed changes

fix(native): widen func-prop guard and fix NOT IN NULL hazard in this…

cd5c987

…-dispatch

carlos-alm added 4 commits June 14, 2026 20:34

fix(cha): align native-orchestrator guards and UNION arm with main

f9a2cfa

docs check acknowledged

fix(cha): sync native-orchestrator UNION arm with main to clear conflict

82bef08

docs check acknowledged

fix(native): narrow func-prop file-selection UNION to exclude class-m…

d1ef1db

…ethod files docs check acknowledged

fix: resolve merge conflicts with main

3755f4f

carlos-alm merged commit 769adf2 into main Jun 15, 2026
27 checks passed

carlos-alm deleted the fix/jelly-micro-parity-1506 branch June 15, 2026 04:26

github-actions Bot locked and limited conversation to collaborators Jun 15, 2026

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506) by carlos-alm · Pull Request #1540 · optave/ops-codegraph-tool · GitHub

Uh oh!

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506) - #1540

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506)#1540
carlos-alm merged 6 commits into
mainfrom
fix/jelly-micro-parity-1506

carlos-alm commented Jun 14, 2026

Uh oh!

greptile-apps Bot commented Jun 14, 2026 •
edited
Loading

Uh oh!

Uh oh!

greptile-apps Bot Jun 14, 2026

Uh oh!

carlos-alm Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026 •
edited
Loading

Uh oh!

Uh oh!

carlos-alm commented Jun 15, 2026

Uh oh!

carlos-alm commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506) by carlos-alm · Pull Request #1540 · optave/ops-codegraph-tool · GitHub

Uh oh!

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506) - #1540

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506)#1540carlos-alm merged 6 commits intomainoptave/ops-codegraph-tool:mainfrom fix/jelly-micro-parity-1506optave/ops-codegraph-tool:fix/jelly-micro-parity-1506Copy head branch name to clipboard

Conversation

carlos-alm commented Jun 14, 2026

Summary

Results

Test plan

Uh oh!

greptile-apps Bot commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

carlos-alm Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codegraph Impact Analysis

Uh oh!

carlos-alm commented Jun 15, 2026

Uh oh!

carlos-alm commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix(cha): eliminate super-dispatch cross-file false edges (jelly-micro #1506)#1540
carlos-alm merged 6 commits into
mainfrom
fix/jelly-micro-parity-1506

greptile-apps Bot commented Jun 14, 2026 •
edited
Loading

github-actions Bot commented Jun 14, 2026 •
edited
Loading