Greptile Summary

This PR fixes a false-positive dead-symbol classification for Rust struct/enum/trait definitions (and equivalent type/interface/record kinds in other languages). Since these forms are consumed via type annotations and struct literals rather than call edges, they always have fan_in=0, causing the old classifier to incorrectly route them through classifyDeadSubRole.

• TypeScript classifier (roles.ts, structure.ts): Introduces TYPE_DEF_KINDS / ANNOTATION_ONLY_KINDS sets and extends the existing constant heuristic to cover all annotation-only kinds.
• Rust native classifier (roles.rs): Mirrors the TypeScript changes with a new TYPE_DEF_KINDS constant and updated classify_node / classify_rows / compute_active_files logic.
• Tests (roles.test.ts): Two new tests cover the happy path and the boundary for the full classification path.

Confidence Score: 5/5

The fix is logically correct and well-tested; safe to merge.

Both the TypeScript and Rust classifiers receive consistent, symmetric changes. The incremental classification path shares the same helper functions and is correctly updated. New tests cover the main scenario and its boundary. The inline annotation_only slice in compute_active_files that manually copies TYPE_DEF_KINDS is a future-maintenance concern, not a current defect.

crates/codegraph-core/src/graph/classifiers/roles.rs — the compute_active_files function uses a local duplicate of TYPE_DEF_KINDS rather than referencing the constant directly.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Node: fan_in = 0, not exported] --> B{is_annotation_only?}
    B -- "kind == constant OR kind in TYPE_DEF_KINDS" --> C{has_active_file_siblings?}
    B -- "regular callable" --> D[classifyDeadSubRole]
    C -- "yes" --> E[leaf]
    C -- "no" --> D
    D --> F[dead-leaf / dead-ffi / dead-unresolved]

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Node: fan_in = 0, not exported] --> B{is_annotation_only?}
    B -- "kind == constant OR kind in TYPE_DEF_KINDS" --> C{has_active_file_siblings?}
    B -- "regular callable" --> D[classifyDeadSubRole]
    C -- "yes" --> E[leaf]
    C -- "no" --> D
    D --> F[dead-leaf / dead-ffi / dead-unresolved]

Reviews (5): Last reviewed commit: "fix: resolve merge conflicts with main" | Re-trigger Greptile

Codegraph Impact Analysis

6 functions changed → 8 callers affected across 3 files

• classify_node in crates/codegraph-core/src/graph/classifiers/roles.rs:115 (3 transitive callers)
• compute_active_files in crates/codegraph-core/src/graph/classifiers/roles.rs:417 (2 transitive callers)
• classify_rows in crates/codegraph-core/src/graph/classifiers/roles.rs:491 (2 transitive callers)
• buildActiveFilesSet in src/features/structure.ts:598 (3 transitive callers)
• buildClassifierInput in src/features/structure.ts:609 (3 transitive callers)
• classifyUnreferencedNode in src/graph/classifiers/roles.ts:109 (4 transitive callers)

Addressed both P2s:

1. Stale JSDoc on hasActiveFileSiblings — updated the field description in src/graph/classifiers/roles.ts to accurately reflect that the field covers all annotation-only kinds (constants plus every member of TYPE_DEF_KINDS), not just constants.

2. Pre-built binary in grammars/tree-sitter-erlang.wasm — this binary was not introduced by this PR. It was committed in PR fix(parity): commit validated tree-sitter-erlang.wasm to restore WASM engine parity #1598 (merged to main as e16b7596) specifically to work around the malicious WhatsApp/tree-sitter-erlang npm package (GHSA-rphw-c8qj-jv84). The diff of this PR against main contains no binary files. The provenance concern was already addressed and reviewed as part of fix(parity): commit validated tree-sitter-erlang.wasm to restore WASM engine parity #1598.

@greptileai