Greptile Summary

This PR has two independent changes: it breaks a 37-file circular dependency in the MCP layer by extracting McpToolContext and McpToolHandler into a new src/mcp/types.ts, and it adds root-level .gitignore awareness to the WASM file-collection walker to replace the previously hard-coded crates directory exclusion.

• MCP cycle fix: McpToolContext / McpToolHandler are moved to src/mcp/types.ts (which only imports from db/index.js). All 35 tool modules and server.ts now import from ./types.js; server.ts re-exports the type for backward compatibility.
• gitignore integration: New readGitignorePatterns() parses the project root .gitignore, compiles non-negated patterns to RegExps via the existing globToRegex, and applies them in both the full filesystem walk (isCollectableSourceFile) and the incremental fast-collect path. Negation patterns and nested .gitignore files are explicitly out of scope.
• Tests: Five new cases in tests/builder/collect-files.test.ts cover the happy path, comment/negation skipping, depth-expansion of bare names, and the end-to-end crates/ regression.

Confidence Score: 5/5

Safe to merge — the MCP refactor is a pure import-path change with no runtime behavior delta, and the gitignore feature is additive with good test coverage for the intended use case.

The cycle-break is a straightforward type extraction with no logic changes; all 35 tool modules change one import path, and server.ts re-exports the type for backward compatibility. The gitignore integration correctly applies root-level patterns to both the full walk and the fast-collect path, and the five new tests cover the stated regression. No broken contracts, no data-path changes.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before (cycle)"]
        S1["server.ts"] -->|imports TOOL_HANDLERS| TI1["tools/index.ts"]
        TI1 -->|imports *| T1["tools/*.ts x35"]
        T1 -->|imports McpToolContext| S1
    end

    subgraph After["After (cycle broken)"]
        MT["mcp/types.ts\n-> db/index.js only"]
        S2["server.ts"] -->|import type McpToolContext| MT
        S2 -->|import TOOL_HANDLERS| TI2["tools/index.ts"]
        TI2 -->|re-export from| MT
        TI2 -->|imports *| T2["tools/*.ts x35"]
        T2 -->|import type McpToolContext| MT
    end

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    subgraph Before["Before (cycle)"]
        S1["server.ts"] -->|imports TOOL_HANDLERS| TI1["tools/index.ts"]
        TI1 -->|imports *| T1["tools/*.ts x35"]
        T1 -->|imports McpToolContext| S1
    end

    subgraph After["After (cycle broken)"]
        MT["mcp/types.ts\n-> db/index.js only"]
        S2["server.ts"] -->|import type McpToolContext| MT
        S2 -->|import TOOL_HANDLERS| TI2["tools/index.ts"]
        TI2 -->|re-export from| MT
        TI2 -->|imports *| T2["tools/*.ts x35"]
        T2 -->|import type McpToolContext| MT
    end

Reviews (3): Last reviewed commit: "fix: replace crates IGNORE_DIRS entry wi..." | Re-trigger Greptile

Codegraph Impact Analysis

8 functions changed → 0 callers affected across 0 files

• McpToolContext.dbPath in src/mcp/types.ts:9 (0 transitive callers)
• McpToolContext.getQueries in src/mcp/types.ts:10 (0 transitive callers)
• McpToolContext.getDatabase in src/mcp/types.ts:11 (0 transitive callers)
• McpToolContext.findDbPath in src/mcp/types.ts:12 (0 transitive callers)
• McpToolContext.allowedRepos in src/mcp/types.ts:13 (0 transitive callers)
• McpToolContext.MCP_MAX_LIMIT in src/mcp/types.ts:14 (0 transitive callers)
• McpToolHandler.name in src/mcp/types.ts:18 (0 transitive callers)
• McpToolHandler.handler in src/mcp/types.ts:19 (0 transitive callers)

@greptileai