fix: skip complexity/CFG for bodyless Rust trait methods (#2053) - #2282
Merged
carlos-alm merged 1 commit intoAug 5, 2026
Merged
fix: skip complexity/CFG for bodyless Rust trait methods (#2053)#2282carlos-alm merged 1 commit into
carlos-alm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
handle_trait_item called compute_all_metrics/build_function_cfg unconditionally for every trait member, including function_signature_item (a required trait method with no default implementation, no body). This fabricated a trivial-but-meaningless complexity entry (cyclomatic: 1, cognitive: 0) that the WASM engine never produces, since COMPLEXITY_RULES for Rust excludes function_signature_item from functionNodes. Gate complexity/cfg on the same bodyless check already used for the Definition.bodyless flag (added in #1922) — function_signature_item gets None for both, function_item (default impl, has a body) is unaffected. Mirrors csharp.rs's handle_interface_decl, which already does this for C# interface methods. Verified native and WASM now produce identical codegraph complexity output on the issue's own repro (Repo.save/Repo.find trait). docs check acknowledged — bug fix restoring engine parity, no new language, feature, or architecture surface to document.
Copy link
Copy Markdown
Contributor
Greptile SummaryThis PR aligns native Rust extraction with the WASM engine by omitting complexity and CFG metadata for bodyless trait method declarations.
Confidence Score: 5/5The PR appears safe to merge, with the targeted native/WASM parity fix covered by a regression test. Bodyless Rust trait methods now retain symbol extraction while omitting inapplicable complexity and CFG data, and default implementations continue through the existing metric-generation path. Important Files Changed
Reviews (1): Last reviewed commit: "fix: skip complexity/CFG for bodyless Ru..." | Re-trigger Greptile |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_trait_item in crates/codegraph-core/src/extractors/rust_lang.rs called compute_all_metrics/build_function_cfg unconditionally for every trait member, including function_signature_item (a required trait method with no default implementation, no body). This fabricated a trivial-but-meaningless complexity entry (cyclomatic: 1, cognitive: 0) that the WASM engine never produces, since COMPLEXITY_RULES for Rust (src/ast-analysis/rules/rust.ts) excludes function_signature_item from functionNodes.
Fix: gate complexity/cfg on the same bodyless check already used for the Definition.bodyless flag (added in #1922) — function_signature_item gets None for both, function_item (default impl, has a body) is unaffected. Mirrors csharp.rs's handle_interface_decl, which already does this for C# interface methods.
Verification
Test plan
Closes #2053