fix(resolver): computed dispatch-table access gets invocation evidence by carlos-alm · Pull Request #2445 · optave/ops-codegraph-tool · GitHub

Summary

{ resolve: someFn } dot-property dispatch-table references already get liveness-gated calls edges once #1895 confirms a real .resolve(...) invocation somewhere. That mechanism never covered the computed/bracket-access idiom:

const handler = TABLE[node.type];
if (handler) handler(node, ctx);

src/extractors/groovy.ts's GROOVY_NODE_HANDLERS dispatch table (and every handler it points to) has fanIn === 0 under this pattern — nothing pointed to any handler via a syntactic edge — so once #2032's reachability downgrade landed, each handler and its own callees were wrongly classified dead, despite being genuinely reachable through the table.

Fix

New collectComputedDispatchTableEvidence/handle_computed_dispatch_table_evidence (TS + Rust) recognizes const handler = TABLE[computedExpr] followed by a later call-site reference to handler in the same enclosing block — reusing #2257's local, position-scoped liveness-scanning machinery (hasLaterReferenceInEnclosingBlock/has_later_reference_in_enclosing_block), extended with a new requireCallSite/require_call_site parameter so the leaf match is restricted to identifiers that are specifically the callee of a call expression, matching #1895's "invoked via call syntax" precision.

Because a computed key can't statically name one specific property the way a dot access can, evidence is credited to the whole table (keyed on the table's own variable name) rather than per-key — the existing keyExpr gate at resolveFallbackTargets/resolve_call_targets now passes when either the per-key evidence or the table-level computed-access evidence is present.

Also fixed: a durable-table parity bug found during verification

While verifying this change end-to-end, tests/integration/issue-1852-watch-cha-pts-dynamic-sink.test.ts's object-rest-param suite started failing — a full native build produced an extra, incorrect calls edge that an incremental rebuild of the identical source correctly omitted.

Root cause: persist_invoked_property_names (import_edges.rs) — the native orchestrator's writer for the durable invoked_property_names table (#2087) — has its own inline copy of the "what counts as invoked-via-member-call-syntax" filter, rather than calling the shared collect_invoked_property_names. That inline copy was missing the dynamic_kind != "value-ref" exclusion this PR's own gate change depends on, so a value-ref call's own bare reference polluted the durable evidence table it later gets checked against — self-confirming its own liveness on every subsequent build. Fixed by applying the same exclusion there, matching the already-correct in-memory collect_invoked_property_names and the TS-side persistInvokedPropertyNames (which already reuses the shared, correctly-scoped helper).

Testing

New extractor unit tests (7 TS + 6 Rust) covering: table-name recorded when later called, not recorded when only referenced, not recorded for string-literal keys, not recorded across a shadowing nested scope, resolves through parenthesized/as-const wrappers, isolates evidence per-table (two tables, only one has call evidence), and a pathological 300-deep nesting stack-safety check.
New dual-engine integration test (tests/integration/issue-2260-computed-dispatch-table-evidence.test.ts) against a Groovy-style dispatch-table fixture, asserting the edge exists on both WASM and native engines and that the handler + its callees are not classified dead.
Full suite: 5008 tests passing (WASM + native).
node scripts/parity-compare.mjs: 42/42 fixtures identical across engines.
npm run lint: clean.

Closes #2260

#2260) docs check acknowledged: internal extractor/resolver fix, no language support, CLI, or architecture-table changes. Impact: 23 functions changed, 33 affected

Heads up: this PR references #2087 without a closing keyword (Closes #N / Fixes #N). If this PR fully resolves #2087, update the description so the issue auto-closes on merge — otherwise disregard this comment.

Greptile Summary

The PR extends dispatch-table liveness inference to computed property access while preserving evidence isolation across files and lexical scopes.

Detects computed table lookups whose selected handler is subsequently invoked.
Threads the evidence through TypeScript, WASM-worker, incremental, FFI, and native Rust paths.
Aligns durable invoked-property filtering and adds dual-engine regression coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/extractors/javascript.ts	Extracts computed-dispatch invocation evidence and consistently qualifies local table identities by their nearest declaring lexical scope.
src/domain/graph/builder/stages/build-edges.ts	Aggregates evidence using file-qualified keys and applies it to value-reference liveness without allowing cross-file collisions.
src/domain/graph/builder/incremental.ts	Applies the same per-file computed-dispatch evidence during watch-mode single-file edge reconstruction.
crates/codegraph-core/src/extractors/javascript.rs	Mirrors the TypeScript extractor’s call-site and lexical-scope evidence semantics for native parsing.
crates/codegraph-core/src/domain/graph/builder/stages/build_edges.rs	Mirrors file-qualified evidence aggregation and liveness gating in the native call-edge resolver.
crates/codegraph-core/src/domain/graph/builder/stages/import_edges.rs	Prevents value references from polluting durable member-invocation evidence during native builds.
tests/integration/issue-2260-computed-dispatch-table-evidence.test.ts	Verifies positive reachability and cross-file, cross-function, and sibling-block isolation for both WASM and native engines.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["TABLE[computedKey]"] --> B["Intermediate handler binding"]
  B --> C{"Later used as call callee?"}
  C -->|No| D["No invocation evidence"]
  C -->|Yes| E["Record file + lexical-scope table identity"]
  E --> F["Match object-literal value references"]
  F --> G["Emit calls edges to table handlers"]

Reviews (4): Last reviewed commit: "fix(extractors): scope dispatch-table di..." | Re-trigger Greptile

Table evidence crosses file boundaries

When two files declare dispatch tables with the same variable name and only one uses computed invocation, this build-wide bare-name set credits both tables. The unrelated table's handlers then receive fabricated calls edges and are incorrectly classified as reachable.

Knowledge Base Used:

Codegraph Impact Analysis

21 functions changed → 37 callers affected across 7 files

collectInvokedPropertyNames in src/domain/graph/builder/call-resolver.ts:91 (9 transitive callers)
buildCallEdges in src/domain/graph/builder/incremental.ts:1490 (5 transitive callers)
buildNativeFileEntry in src/domain/graph/builder/stages/build-edges.ts:812 (3 transitive callers)
computedDispatchTableEvidenceKey in src/domain/graph/builder/stages/build-edges.ts:1354 (5 transitive callers)
buildCallEdgesJS in src/domain/graph/builder/stages/build-edges.ts:1358 (3 transitive callers)
resolveFallbackTargets in src/domain/graph/builder/stages/build-edges.ts:1717 (3 transitive callers)
buildFileCallEdges in src/domain/graph/builder/stages/build-edges.ts:2197 (3 transitive callers)
serializeExtractorOutput in src/domain/wasm-worker-entry.ts:685 (2 transitive callers)
deserializeBindingFields in src/domain/wasm-worker-pool.ts:116 (2 transitive callers)
extractSymbolsQuery in src/extractors/javascript.ts:422 (3 transitive callers)
extractSymbolsWalk in src/extractors/javascript.ts:1366 (3 transitive callers)
findDeclaringScopeLine in src/extractors/javascript.ts:4222 (15 transitive callers)
findEnclosingTableName in src/extractors/javascript.ts:4251 (15 transitive callers)
collectObjectLiteralValueRefCall in src/extractors/javascript.ts:4295 (14 transitive callers)
scanPatternDefaultsForReference in src/extractors/javascript.ts:4616 (4 transitive callers)
isCallCallee in src/extractors/javascript.ts:4728 (5 transitive callers)
blockContainsIdentifierExcluding in src/extractors/javascript.ts:4737 (5 transitive callers)
hasLaterReferenceInEnclosingBlock in src/extractors/javascript.ts:4892 (14 transitive callers)
collectComputedDispatchTableEvidence in src/extractors/javascript.ts:5019 (14 transitive callers)
runCollectorWalk in src/extractors/javascript.ts:5951 (5 transitive callers)

Greptile review, PR #2445: the evidence set was keyed on the table's bare variable name across the whole build pass, so two unrelated files declaring a same-named table (e.g. HANDLERS) would leak evidence — one file's confirmed computed-invocation would wrongly credit the other file's same-named-but-unrelated table with a live calls edge. Both engines now key the set on file::tableName, mirroring the existing callee::restName (#1358) and cha_*_by_file (#2237) scoping conventions. docs check acknowledged: internal extractor/resolver fix, no language support, CLI, or architecture-table changes. Impact: 3 functions changed, 6 affected

@greptileai

Evidence crosses lexical scopes

When two lexical scopes in one file declare dispatch tables with the same variable name and only one performs a computed invocation, this file-and-name key credits both bindings. Handlers belonging only to the uninvoked table then receive fabricated calls edges and are incorrectly classified as reachable.

Knowledge Base Used:

#2260) Greptile review, PR #2445 round 2: file+name scoping still let two different functions in one file, each declaring their own same-named local dispatch table, share one evidence-set entry when only one performed a computed invocation. findEnclosingTableName/ find_enclosing_table_name now suffix the table name with its enclosing function's qualifier (reusing the existing findEnclosingFunctionQualifier/find_enclosing_function_qualifier machinery from #2033) when the declaration is function-scoped; the consumer side matches via a new findConsumerTableScopeQualifier/find_consumer_table_scope_qualifier that walks outward checking introducesShadowedBinding/ introduces_shadowed_binding (#2257) at each enclosing function level. A module-scoped table (the common case) is unaffected — no suffix. docs check acknowledged: internal extractor/resolver fix, no language support, CLI, or architecture-table changes. Impact: 3 functions changed, 11 affected

@greptileai

Block-scoped tables still collide

When sibling blocks in one function declare same-named dispatch tables and only one invokes a computed handler, both declarations and the invocation evidence receive the same function-qualified table name. The resolver consequently credits the uninvoked table too, fabricating calls edges and incorrectly classifying its handlers as reachable.

Knowledge Base Used:

…t just functions (#2260) Greptile review, PR #2445 round 3: function-level disambiguation still let two sibling blocks in the SAME function (an if/else), each declaring their own same-named local table, share one evidence-set entry. findEnclosingTableName/find_enclosing_table_name and collectComputedDispatchTableEvidence/handle_computed_dispatch_table_evidence now share one walker (findDeclaringScopeLine/find_declaring_scope_line) that checks introducesShadowedBinding/introduces_shadowed_binding (#2257) at EVERY enclosing scope level, not just function boundaries, identifying a match by its own line rather than a function qualifier name (a bare block has none). A module-scoped table (the common case) is still unaffected — no suffix. docs check acknowledged: internal extractor/resolver fix, no language support, CLI, or architecture-table changes. Impact: 3 functions changed, 0 affected

@greptileai

fix(resolver): computed dispatch-table access gets invocation evidence (

f7dd6d2

#2260) docs check acknowledged: internal extractor/resolver fix, no language support, CLI, or architecture-table changes. Impact: 23 functions changed, 33 affected

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

carlos-alm merged commit 599a4f0 into main Aug 10, 2026
12 checks passed

carlos-alm deleted the fix/issue-2260-computed-dispatch-table-evidence branch August 10, 2026 16:06

github-actions Bot locked and limited conversation to collaborators Aug 10, 2026

+                const computedDispatchTableEvidence = new Set<string>();
+                for (const symbols of fileSymbols.values()) {
+                  for (const name of symbols.computedDispatchTableEvidence ?? []) {
+                    computedDispatchTableEvidence.add(name);
+                  }
+                }

+                  if (FUNCTION_SCOPE_TYPES.has(current.type)) {
+                    const body = current.childForFieldName('body');
+                    if (body && introducesShadowedBinding(body, tableName)) {
+                      return qualifierForFunctionScopeNode(current) ?? undefined;

fix(resolver): computed dispatch-table access gets invocation evidence by carlos-alm · Pull Request #2445 · optave/ops-codegraph-tool · GitHub

Uh oh!

fix(resolver): computed dispatch-table access gets invocation evidence - #2445

fix(resolver): computed dispatch-table access gets invocation evidence#2445
carlos-alm merged 4 commits into
mainfrom
fix/issue-2260-computed-dispatch-table-evidence

carlos-alm commented Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

greptile-apps Bot commented Aug 10, 2026 •
edited
Loading

Uh oh!

Uh oh!

greptile-apps Bot Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Uh oh!

Uh oh!

carlos-alm commented Aug 10, 2026

Uh oh!

greptile-apps Bot Aug 10, 2026

Uh oh!

carlos-alm commented Aug 10, 2026

Uh oh!

greptile-apps Bot Aug 10, 2026

Uh oh!

carlos-alm commented Aug 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		function computedDispatchTableEvidenceKey(relPath: string, tableName: string): string {
		return `${relPath}::${tableName}`;

fix(resolver): computed dispatch-table access gets invocation evidence by carlos-alm · Pull Request #2445 · optave/ops-codegraph-tool · GitHub

Uh oh!

fix(resolver): computed dispatch-table access gets invocation evidence - #2445

Conversation

carlos-alm commented Aug 10, 2026

Summary

Fix

Also fixed: a durable-table parity bug found during verification

Testing

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

greptile-apps Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codegraph Impact Analysis

Uh oh!

carlos-alm commented Aug 10, 2026

Uh oh!

greptile-apps Bot Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

carlos-alm commented Aug 10, 2026

Uh oh!

greptile-apps Bot Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

carlos-alm commented Aug 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps Bot commented Aug 10, 2026 •
edited
Loading

github-actions Bot commented Aug 10, 2026 •
edited
Loading