exception type and other util - #42
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
| * @since 0.1.1 | ||
| */ | ||
| public class CompressorFactory { | ||
| public class RandomUtil { |
There was a problem hiding this comment.
这个也不需要，依赖的库里面有
Sorry, something went wrong.
| * @param channelId channelId | ||
| * @param frameNumber channel frame number | ||
| */ | ||
| public record TxData(byte[] data, byte[] channelId, int frameNumber) { |
There was a problem hiding this comment.
这个node里面有吗？
Sorry, something went wrong.
There was a problem hiding this comment.
这个是frame变了一个形式，可直接使用Frame，已移除
Sorry, something went wrong.
| * either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
包名不要缩写，另外exception不用都放一块，除非是会共用的
Sorry, something went wrong.
There was a problem hiding this comment.
好的，这个是公共的，不同的包内都会使用
Sorry, something went wrong.
| if (p.length > avail) { | ||
| readLen = avail; | ||
| } | ||
| System.arraycopy(data, pos, p, 0, readLen); |
There was a problem hiding this comment.
可以用arrayUtils或者arrays简化下代码吧，你看下node里面的batches
Sorry, something went wrong.
There was a problem hiding this comment.
这里需要把数据填充到参数里的byte[]里。
ArrayUtils和Arrays工具都是返回一个新创建的数组，没办法替换System.arraycopy这个操作。
Sorry, something went wrong.
There was a problem hiding this comment.
copy应该也有工具方法吧
Sorry, something went wrong.
exception type and util