Add stun server for ip discovery and flag stun - #181
Merged
r4f4ss merged 3 commits intoOct 5, 2024
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@r4f4ss (nit) Could this feature have a test? |
Sorry, something went wrong.
fearlessfe
reviewed
Oct 4, 2024
fearlessfe
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
It just create a STUN{}, It should be a place to get the real IP and set to the localNode
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Added function main.doPortMapping that set address and port for localNode, reference implementation from: Line 153 in ee38628 |
Sorry, something went wrong.
fearlessfe
approved these changes
Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #176
new usage (reference usage):
or