I think we can abstract a Metrics interface and add an implementation called NoMetrics, where all methods are empty.

When metrics are not needed, we can use an instance of NoMetrics, so we don't have to check metrics.Enable every time.

I think we can abstract a Metrics interface and add an implementation called NoMetrics, where all methods are empty.

When metrics are not needed, we can use an instance of NoMetrics, so we don't have to check metrics.Enable every time.

Definitely will make the code more clear, but I am not sure if a function call to the interface is computationally cheapper than an if verification. As alternative, what about replace the duplicate code:

if metrics.Enabled {
	portalStorageMetrics.EntriesCount.Dec(count)
}

in a function that verify:

func verifyDec(metric){
    if metrics.Enabled {
	    metric.Dec(count)
    }
}

and it is more clear in the code to call simple:

verifyDec(metric)

EDIT: Nevermind, It is the worst solution, uses an function call and an if comparison, higher computationally cost

I think we can abstract a Metrics interface and add an implementation called NoMetrics, where all methods are empty.
When metrics are not needed, we can use an instance of NoMetrics, so we don't have to check metrics.Enable every time.

Definitely will make the code more clear, but I am not sure if a function call to the interface is computationally cheapper than an if verification. As alternative, what about replace the duplicate code:

if metrics.Enabled {
	portalStorageMetrics.EntriesCount.Dec(count)
}

in a function that verify:

func verifyDec(metric){
    if metrics.Enabled {
	    metric.Dec(count)
    }
}

and it is more clear in the code to call simple:

verifyDec(metric)

EDIT: Nevermind, It is the worst solution, uses an function call and an if comparison, higher computationally cost

Just follow the geth style is OK.

By the way, the code of storage is according from the early version of the trin. Now, the trin has update the storage code, maybe we can check there code to decide if we should do some update.