feat:add lc bootstrap and update range - #72
Merged
GrapeBaBa merged 2 commits intoApr 7, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Chen Kai <281165273grape@gmail.com>
fearlessfe
reviewed
Apr 6, 2024
Comment thread
portalnetwork/beacon/types.go
Outdated
|
|
||
| func (flb *ForkedLightClientBootstrap) Deserialize(dr *codec.DecodingReader) error { | ||
| _, err := dr.Read(flb.ForkDigest[:]) | ||
| func (flcb *ForkedLightClientBootstrap) Deserialize(dr *codec.DecodingReader) error { |
Copy link
Copy Markdown
There was a problem hiding this comment.
use spec *common.Spec as first arg, the same as Serialize, ByteLength etc. use arg spec replace the configs.Mainnet
Sorry, something went wrong.
fearlessfe
reviewed
Apr 6, 2024
Comment thread
portalnetwork/beacon/types.go
Outdated
|
|
||
| func (flb *ForkedLightClientBootstrap) FixedLength() uint64 { | ||
| func (flcb *ForkedLightClientBootstrap) Serialize(w *codec.EncodingWriter) error { | ||
| if err := w.Write(flcb.ForkDigest[:]); err != nil { |
Copy link
Copy Markdown
There was a problem hiding this comment.
if the first arg is spec, maybe you can try this
return w.Container(&flcb.ForkDigest, spec.Wrap(&flcb.Bootstrap))
Sorry, something went wrong.
Signed-off-by: Chen Kai <281165273grape@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #73