FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

purge six (even the vendored one) from non-vendored files by MeggyCal · Pull Request #642 · oracle/oci-python-sdk · GitHub

purge six (even the vendored one) from non-vendored files - #642

Open
MeggyCal wants to merge 1 commit into
oracle:masterfrom
MeggyCal:master
Open

purge six (even the vendored one) from non-vendored files#642
MeggyCal wants to merge 1 commit into
oracle:masterfrom
MeggyCal:master

Conversation

Copy link
Copy Markdown

As this library is Python 3 only, it shouldn't need six to run. It is a preparation for Python 3.13, however, some dependencies still need six.

Some files I edited by hand, but most work was done by sed scripts, namely:
sed -i '/import six/d'
sed -i 's/six.iter\([a-z]\+\)(\([_\.a-z]\+\))/\2.\1()/g'
sed -i 's/six.string_types/str/g' and friends (the same with binary_type, integer_types, etc)

If there is any mistake, typo, anything, let me know :) .

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Apr 18, 2024

Copy link
Copy Markdown
Author

Well, I am reluctant to create an account... I will think about that.

MeggyCal commented Apr 18, 2024
edited
Loading

Copy link
Copy Markdown
Author

Anyway, I give anyone my permission to use those sed scripts (or even copy my commit) and basically bypass my PR. I just want this library to work even after six dies.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL