Feature/loading screen - #43
Open
Laurell876 wants to merge 5 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Closed
heyjordn
suggested changes
Mar 3, 2021
heyjordn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please stick to the established conventions. Why would we pollute the main typescript file with all of this markdown, this makes this file near impossible to read and understand
Sorry, something went wrong.
Comment thread
packages/core/src/index.ts
Outdated
|
|
||
| //Set Loading state | ||
| button.setState("loading"); | ||
| loadingDiv.innerHTML = ` |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is ridiculous, why are cluttering the main index file with all of this markdown?!
Sorry, something went wrong.
Laurell876
force-pushed
the
feature/loading-screen
branch
from
8bc4f79 to
c8bb2d7
Compare
May 12, 2021 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of how loading screen looks when the user clicks the rendered button